8000 [Validator] Add constraint on unique elements collection(Assert\Unique) · Issue #26535 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Validator] Add constraint on unique elements collection(Assert\Unique) #26535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zzenmate opened this issue Mar 14, 2018 · 2 comments
Closed

[Validator] Add constraint on unique elements collection(Assert\Unique) #26535

zzenmate opened this issue Mar 14, 2018 · 2 comments
Labels
Feature Validator

Comments

@zzenmate
Copy link
zzenmate commented Mar 14, 2018 •
edited
Loading
Q A
Bug report? no
Feature request? yes
BC Break report? no
RFC? no
Symfony version 4.1

What about add constraint on unique elements collection?
I think it will be named as Assert\UniqueCollection.
It is partly linked with #9888
What do you think? I'd be happy to send a PR after it's discussed.
@zzenmate zzenmate mentioned this issue Mar 15, 2018
Merged
@ostrolucky
Copy link
Contributor
ostrolucky commented Mar 15, 2018 •
edited
Loading

Another duplicate of #9888 But you are free to implement this part at least. It's easiest one anyway.

@zzenmate zzenmate changed the title [Validator] Add constraint on unique elements collection(Assert\UniqueCollection) [Validator] Add constraint on unique elements collection(Assert\Unique) Mar 18, 2018
@xabbuh
Copy link
Member
xabbuh commented Sep 24, 2018

closing here as this feature request is included in #9888

@xabbuh xabbuh closed this as completed Sep 24, 2018
fabpot added a commit that referenced this issue Mar 25, 2019
@fabpot
feature #26555 [Validator] Add constraint on unique elements collecti…
c146744 
…on(Assert\Unique) (zenmate, nicolas-grekas)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Validator] Add constraint on unique elements collection(Assert\Unique)

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | no    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #26535
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

d0eb13e Rebase and update to latest CS
fc66683 Add UniqueCollection constraint and validator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Validator
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ostrolucky @xabbuh @zzenmate
0