8000 BC break in 3.4 cache warming · Issue #26506 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content
BC break in 3.4 cache warming #26506
Closed
Closed
@lxg

Description

@lxg
Q A
Bug report? yes
Feature request? no
BC Break report? yes
RFC? no
Symfony version 3.4

There seems to be a BC break in Symfony 3.4 when clearing/warming the cache.

Until a couple of days ago, it was possible to write to %kernel.cache_dir% during cache warming and the contents would persist. Now they are deleted when the cache directory is moved from de_ to dev. However, when using the $cacheDir parameter provided to the warmUp method, the files are kept.

I realize that using the path provided to warmUp is preferred, but we have different places in our code base where the path is injected to cache warming services through the service configuration. This way, we can configure a common path for shared cache objects and use a common cache service.

Example:

https://gist.github.com/lxg/de91dad64059a63c3ffed0e4179aa057
https://gist.github.com/lxg/05299c118bba0db197327cb1b07ca091

I agree that this could be solved differently. However, this change breaks the previous behaviour which has been there since several years.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0