Missing final keywords on Process class for v4

Q	A
Bug report?	yes (kindof)
Feature request?	no
BC Break report?	no
RFC?	no
Symfony version	4.0.3

The following methods should be final since v4.0:

run:

symfony/src/Symfony/Component/Process/Process.php

Lines 195 to 197 in ddb602b

    
                * @final since version 3.3 
        
                */ 
        
               public function run(callable $callback = null, array $env = array()): int

mustRun:

symfony/src/Symfony/Component/Process/Process.php

Lines 217 to 219 in ddb602b

< 6739 td id="LC219" class="blob-code border-0 px-3 py-0 color-bg-default blob-code-inner js-file-line"> publicfunctionmustRun(callable$callback = null, array$env = array())

* @final since version 3.3

*/

restart:

symfony/src/Symfony/Component/Process/Process.php

Lines 336 to 338 in ddb602b

    
                * @final since version 3.3 
        
                */ 
        
               public function restart(callable $callback = null, array $env = array())

But they are not. Is this wanted or it was something missed before the release of v4?

Upgrade ref: https://github.com/symfony/symfony/blob/3.4/UPGRADE-3.3.md#process

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	* @final since version 3.3
	*/
	public function run(callable $callback = null, array $env = array()): int

	* @final since version 3.3
	*/
	public function restart(callable $callback = null, array $env = array())

Uh oh!

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions