[TwigBridge][RFC] Automatically extract route params from objects in path() and url() #25276

vudaltsov · 2017-12-02T18:44:46Z

Q	A
Bug report?	no
Feature request?	yes
BC Break report?	no
RFC?	yes
Symfony version	4.1

This is an idea on how to replace this

{{ path('app_news', {alias: news.alias}) }}
{{ path('app_blog_post', {id: blog.id}) }}

with

{{ path('app_news', news) }}
{{ path('app_blog_post', blog) }}

<?php

namespace Symfony\Bridge\Twig\Extension;

use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
use Twig\Extension\AbstractExtension;
use Twig\TwigFunction;

class RoutingExtension extends AbstractExtension
{
    private $generator;
    private $router;
    private $accessor;

    public function __construct(UrlGeneratorInterface $generator, RouterInterface $router, PropertyAccessorInterface $accessor)
    {
        $this->generator = $generator;
        $this->router = $router;
        $this->accessor = $accessor;
    }

    public function getFunctions()
    {
        return array(
            // same for url
            new TwigFunction('path', array($this, 'getPath')),
        );
    }

    public function getPath($name, $parameters = array(), $relative = false)
    {
        if (is_object($parameters)) {
            $parameters = $this->getObjectParameters($name, $parameters);
        }

        return $this->generator->generate($name, $parameters, $relative ? UrlGeneratorInterface::RELATIVE_PATH : UrlGeneratorInterface::ABSOLUTE_PATH);
    }

    private function getObjectParameters($name, $object)
    {
        $parameters = [];

        $route = $this->router
            ->getRouteCollection()
            ->get($name);

        if (null !== $route) {
            foreach ($route->compile()->getVariables() as $variable) {
                if ($this->accessor->isReadable($object, $variable)) {
                    $parameters[$variable] = $this->accessor->getValue($object, $variable);
                }
            }
        }

        return $parameters;
    }
}

Koc · 2017-12-03T10:20:40Z

duplicates #10395, #2288, #5999

vudaltsov · 2017-12-03T11:19:54Z

@Koc , thanx, got it :)

zmitic · 2018-01-04T15:23:58Z

@vudaltsov In case you are still looking for a solution, check the bundle I released today:

https://github.com/zmitic/rewire-bundle

It works by adding one annotation in your route and I didn't notice any perfomance issues for a page with around 100 links (didn't test for more).

Feedback is more than welcome.

vudaltsov · 2018-01-04T20:36:37Z

@zmitic , thanx. I will try it later and give feedback!

vudaltsov changed the title ~~[TwigBridge][RFC] Allow to pass objects to~~ [TwigBridge][RFC] Automatically extract route params from objects in path() and url() Dec 2, 2017

vudaltsov closed this as completed Dec 3, 2017

xabbuh added the Routing label Dec 4, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[TwigBridge][RFC] Automatically extract route params from objects in path() and url() #25276

[TwigBridge][RFC] Automatically extract route params from objects in path() and url() #25276

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

[TwigBridge][RFC] Automatically extract route params from objects in path() and url() #25276

[TwigBridge][RFC] Automatically extract route params from objects in path() and url() #25276

Comments

Uh oh!

Uh oh!

Uh oh!

Uh oh!