8000 [DX][WebProfilerBundle] Add a link to open twig template · Issue #25118 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content
8000

[DX][WebProfilerBundle] Add a link to open twig template #25118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lyrixx opened this issue Nov 22, 2017 · 6 comments
Closed

[DX][WebProfilerBundle] Add a link to open twig template #25118

lyrixx opened this issue Nov 22, 2017 · 6 comments

Comments

@lyrixx
Copy link
Member
lyrixx commented Nov 22, 2017
Q A
Bug report? no
Feature request? no
BC Break report? no
RFC? yes
Symfony version master

image

On this image, I would like to be able to click on the template name to open directly the open in my IDE.

Plus It would be awesome if the (fist?) rendered template could be clickable too from the toolbar (in the bottom of a page). I guess this could be hard, as a this is not necessarily the first template to be rendered: For exemple if one render a template to send it by mail.

WDYT? Is it hard to implement?

@ogizanagi
Copy link
Contributor

I think it's already done in #24236 and available in 3.4 :)

Being able to access the rendered template(s) from the toolbar was also suggested in #24236 (comment).

@ro0NL
Copy link
Contributor
ro0NL commented Nov 23, 2017

@lyrixx anything to do? :-)

@lyrixx
Copy link
Member Author
lyrixx commented Nov 23, 2017

yes, it would be awesome to be able to open my IDE on the "first" rendered template.

@lyrixx
Copy link
Member Author
lyrixx commented Nov 23, 2017

BTW, thanks for #24236 I missed it.

@javiereguiluz
Copy link
Member

@lyrixx as you said in the description, getting the right Twig template in every situation can be very difficult (impossible?). Not sure the added complexity is worth it for a feature that will probably not work perfectly right.

@lyrixx
Copy link
Member Author
lyrixx commented Nov 23, 2017

Okay, let's close this issue ;)

@lyrixx lyrixx closed this as completed Nov 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants
0