8000 [Workflow] Initialize without any pre-configured workflows · Issue #24051 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Workflow] Initialize without any pre-configured workflows #24051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nea opened this issue Aug 31, 2017 · 4 comments
Closed

[Workflow] Initialize without any pre-configured workflows #24051

nea opened this issue Aug 31, 2017 · 4 comments
Labels
Feature Workflow

Comments

@nea
Copy link
nea commented Aug 31, 2017
Q A
Bug report? no
Feature request? yes
BC Break report? yes/no
RFC? yes/no
Symfony version 3.3

Hi everyone

I am looking into the workflow component as it would pose a very interesting solution for many use cases we are facing.
We are especially looking into dynamically working with the workflows and initializing them.

But there is one thing, I want to ask if reasonable to change in line https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php#L476

Does it make sense, to not load the services if no global workflows are configured? Right now, I have defined a dummy workflow to be able to access the registry to add additional, dynamic workflows.

If at least everything is initialized from the beginning, the registry could be used later on to configure workflows more dynamically.

Does that make sense what I am babbling about ^^? Or is there a specific reason for the current design decision I do not see?

Thanks a lot in advance
@ro0NL
Copy link
Contributor
ro0NL commented Sep 1, 2017 •
edited
Loading

I think the trick is to support framework.workflows: false which explicitly disables. And perhaps framework.workflows: ~|true to enable without any workflows configured.

@nea
Copy link
Author
nea commented Sep 4, 2017

Hi @ro0NL

I tried ~ (same idea ^^) but didn't work out. Also tried with an empty array but then the validation kicks in as it iterates the content and fails the validation (unfortunately).

Thanks

@ro0NL
Copy link
Contributor
ro0NL commented Sep 4, 2017

Yeah we need to patch that first :)

@xabbuh xabbuh mentioned this issue Sep 4, 2017
Merged
@xabbuh
Copy link
Member
xabbuh commented Sep 4, 2017

see #24093

fabpot added a commit that referenced this issue Sep 5, 2017
@fabpot
feature #24093 [FrameworkBundle] be able to enable workflow support e…
3d799dd 
…xplicitly (xabbuh)

This PR was merged into the 3.4 branch.

Discussion
----------

[FrameworkBundle] be able to enable workflow support explicitly

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #24051
| License       | MIT
| Doc PR        |

Commits
-------

eaa506f be able to enable workflow support explicitly
@fabpot fabpot closed this as completed Sep 5, 2017
@xabbuh xabbuh mentioned this issue Oct 31, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Workflow
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fabpot @nea @ro0NL @xabbuh
0