10000 Cannot advance a workflow with a guard from a command, even if the guard never checks the user · Issue #23904 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Cannot advance a workflow with a guard from a command, even if the guard never checks the user #23904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
GDIBass opened this issue Aug 16, 2017 · 0 comments
Closed

Cannot advance a workflow with a guard from a command, even if the guard never checks the user #23904

GDIBass opened this issue Aug 16, 2017 · 0 comments
Labels
Bug Status: Needs Review Workflow

Comments

@GDIBass
Copy link
Contributor
GDIBass commented Aug 16, 2017 •
edited by chalasr
Loading
Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? yes
Symfony version 3.3.0

Attempting to advance a workflow with a guard from the command line produces an Exception.

To reproduce:

  1. Create a workflow with a guard on the subject, not on roles
  2. Create a command that attempts to advance the workflow
  3. Run the command

PR: #23906
@GDIBass GDIBass mentioned this issue Oct 5, 2017
Merged
fabpot added a commit that referenced this issue Oct 5, 2017
@fabpot
bug #23906 Added support for guards when advancing workflow from a co…
9568fae 
…mmand (GDIBass)

This PR was merged into the 3.3 branch.

Discussion
----------

Added support for guards when advancing workflow from a command

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23904
| License       | MIT
| Doc PR        | symfony/symfony-docs

Added support for advancing a workflow from the command line when the transition has guards.

Commits
-------

15fd863 Updated Test name and exception name to be more accurate
fefc202 newline at end of file
8f2fa6b changed exception message
49839e3 Ahh, I see.  It actually wants a newline!
2c9d1e2 Removed newline
92308b4 Created new Exception to throw and modified tests.
2ebc71a Created new Exception to throw and modified tests
3a8b2ed Code standard fixes
22b44e2 Changed automatic token generation to throw an exception instead
8ab59cb Updated if statement
324c208 Code standards update
b044ffb Added support for guards when advancing workflow from a command
@fabpot fabpot closed this as completed Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Status: Needs Review Workflow
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fabpot @xabbuh @GDIBass @carsonbot
0