8000 [RFC] Deprecate the web_profiler.position option · Issue #23528 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content
[RFC] Deprecate the web_profiler.position option #23528
Closed
@javiereguiluz

Description

@javiereguiluz
Q A
Bug report? no
Feature request? no
BC Break report? no
RFC? yes
Symfony version 3.4

This config option allows to display the debug toolbar at the top of the browser window instead of the default bottom position.

In the past we required this option because the old profiler displayed the toolbar at the top ... but the new profiler no longer needs it because it doesn't display the toolbar.

Although this may look as a small option, it requires some code to manage it:

  • The config code to define and validate the position option in web_profiler
  • The toolbarPosition argument is passed around in some profiler controllers
  • The CSS styles must define special styles when the toolbar is at the top
  • We even create a container parameter for this! web_profiler.debug_toolbar.position

Now that we don't need this option for ourselves, I propose to deprecate it in 3.4 and remove it in 4.0.

Metadata

Metadata

Assignees

No one assigned

    Labels

    RFCRFC = Request For Comments (proposals about features that you want to be discussed)WebProfilerBundle

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0