8000 [Process] Adding exec breaks functionality that does this manually · Issue #22476 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Process] Adding exec breaks functionality that does this manually #22476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mariusbalcytis opened this issue Apr 19, 2017 · 1 comment
Closed

[Process] Adding exec breaks functionality that does this manually #22476

mariusbalcytis opened this issue Apr 19, 2017 · 1 comment
Labels
BC Break Bug Process Status: Needs Review

Comments

@mariusbalcytis
Copy link
mariusbalcytis commented Apr 19, 2017 •
edited
Loading
Q A
Bug report? yes
Feature request? no
BC Break report? yes
RFC? no
Symfony version 3.3

If exec is added manually in front of process command line, adding it automatically breaks things.

Working example in 3.2 version:

melody run https://gist.github.com/mariusbalcytis/65b5799db0c04f0f82eb97c2be77db40

Stopped working in 3.3 version:

melody run https://gist.github.com/mariusbalcytis/5b28910592485b69fe9a26b926913afb

I'd say that this could be implemented in quite a lot of places - in fact, if PhpProcess class would be in different component, it would have stopped working, too (as it added exec manually).
@mariusbalcytis
Copy link
Author

This was introduced in #21474.

@xabbuh xabbuh added this to the 3.3 milestone Apr 20, 2017
@nicolas-grekas nicolas-grekas removed this from the 3.3 milestone Apr 20, 2017
@nicolas-grekas nicolas-grekas mentioned this issue Apr 20, 2017
Merged
This was referenced Apr 22, 2017
Closed
Closed
@fabpot fabpot closed this as completed Apr 25, 2017
fabpot added a commit that referenced this issue Apr 25, 2017
@fabpot
bug #22487 [Process] Fix BC break: "exec" should remain an internal "…
63dca04 
…detail" (nicolas-grekas)

This PR was merged into the 3.3-dev branch.

Discussion
----------

[Process] Fix BC break: "exec" should remain an internal "detail"

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #22476
| License       | MIT
| Doc PR        | -

Commits
-------

eedcece [Process] Fix BC break: "exec" should remain an internal "detail"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BC Break Bug Process Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@fabpot @nicolas-grekas @mariusbalcytis @xabbuh @carsonbot
0