8000 [DX][Form] Ability to disable the checkMX of email validator for dev environment · Issue #20226 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DX][Form] Ability to disable the checkMX of email validator for dev environment #20226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Nek- opened this issue Oct 16, 2016 · 5 comments
Closed

[DX][Form] Ability to disable the checkMX of email validator for dev environment #20226

Nek- opened this issue Oct 16, 2016 · 5 comments

Comments

@Nek-
Copy link
Contributor
Nek- commented Oct 16, 2016 •
edited
Loading

The check mx is a great feature of the email validator but doesn't allow you to test your form type without an internet connection. Which is a problem for example for people who work in a train or in the middle of nowhere just behind an awesome lake.

There were a PR that would fix this problem: #18142

But the spotted use case was only "test env". And considering that fact, the solution was not optimal. But if you consider also the dev environment... I think the PR should be re-considered.

What do you think ? Do you want me to take care of that ?
@Nek- Nek- changed the title [DX] Ability to disable the checkMX of email validator for dev environment [DX][Form] Ability to disable the checkMX of email validator for dev environment Oct 16, 2016
@linaori
Copy link
Contributor
linaori commented Oct 16, 2016

You can't ever trust DNS records a full 100%, think about changes and TTL for example. The only way to verify if an email address is valid, is by sending mail. While the check itself can be nice, I don't think it's too relevant for email validation. Mx records can give false negatives (if that's what you call it).

@fabpot
Copy link
Member
fabpot commented Oct 16, 2016

I agree with @iltar that this option should IMO never be used as it's more or useless. If it were just me, I would just remove this option altogether.

@fabpot fabpot closed this as completed Oct 16, 2016
@Nek-
Copy link
Contributor Author
Nek- commented Oct 16, 2016

@iltar @fabpot

TTL problem is like "not working properly for your super custom email for some hours", most part of the time (and for most users) it's ok.

Btw you dislike this (pretty cool) option enough to close an issue about for it ? :) So why not deprecate it and remove it definitely from Symfony ?

@linaori
Copy link
Contributor
linaori commented Oct 16, 2016

Actually, Most people don't know that mx (or dns checks in General) are not
reliable. When using this check, it gave false negatives all the time for
me (partially cause I'm in the hosting business)

On Sun, 16 Oct 2016, 19:46 Maxime Veber, notifications@github.com wrote:

@iltar https://github.com/iltar @fabpot https://github.com/fabpot

TTL problem is like "not working properly for your super custom email for
some hours", most part of the time (and for most users) it's ok.

Btw you dislike this (pretty cool) option enough to close an issue about
for it ? :) So why not deprecate it and remove it definitely from Symfony ?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#20226 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABrGNlLtzQese1ZSNo8md5CNeXkK-fdjks5q0mL7gaJpZM4KYAl5
.

@fabpot
Copy link
Member
fabpot commented Oct 16, 2016

I do think that deprecating this option and removing it in 4.0 is the way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fabpot @Nek- @linaori
0