Broken tests in master: Could not scan for classes inside "tests/" #20032

linaori · 2016-09-23T10:27:39Z

It seems like some commit broke at least the master. If I run ./phpunit it crashes after installing the packages with:


  [RuntimeException]                                                                          
  Could not scan for classes inside "tests/" which does not appear to be a file nor a folder

I did a bit of digging and the only reference I found was a classmap option in composer.json from the zip file in the .phpunit directory. Sadly I was unable to fix it myself as it keeps overwriting everything.

ping @nicolas-grekas

The text was updated successfully, but these errors were encountered:

nicolas-grekas · 2016-09-23T10:47:44Z

where does this tests/ string come from?

nicolas-grekas · 2016-09-23T10:48:16Z

Any backtrace?

linaori · 2016-09-23T10:50:51Z

I can't summon a back-trace, I think it's invoked by a sub-process of the phpunit bash file that runs an include. I can't find tests/ other than in a zip file where it's defined in the class-map options.

stof · 2016-09-23T10:51:16Z

@iltar do you have a phpunit.xml file locally, replacing the phpunit.xml.dist shipped in the repo ?

linaori · 2016-09-23T10:54:00Z

No, I have everything stock, I was reproducing this issue for @stampycode

linaori · 2016-09-23T10:57:32Z

A bit more info:

alcohol · 2016-09-23T11:23:38Z

I can get the test suite to run (though with a lot of failures) by modifying the following binary:

vendor/symfony/phpunit-bridge/bin/simple-phpunit

diff --git i/bin/simple-phpunit w/bin/simple-phpunit
index 14a9d1c..a8c1581 100755
--- i/bin/simple-phpunit
+++ w/bin/simple-phpunit
@@ -53,8 +53,8 @@ if (!file_exists("$PHPUNIT_DIR/phpunit-$PHPUNIT_VERSION/phpunit") || md5_file(__
     if (5.1 <= $PHPUNIT_VERSION && $PHPUNIT_VERSION < 5.4) {
         passthru("$COMPOSER require --no-update phpunit/phpunit-mock-objects \"~3.1.0\"");
     }
-    passthru("$COMPOSER require --dev --no-update symfony/phpunit-bridge \">=3.2@dev\"");
-    passthru("$COMPOSER install --prefer-dist --no-progress --ansi", $exit);
+    passthru("$COMPOSER require --no-update symfony/phpunit-bridge \">=3.2@dev\"");
+    passthru("$COMPOSER install --no-dev --prefer-dist --no-progress --ansi", $exit);
     if ($exit) {
         exit($exit);
     }

The zipfile downloaded by this binary does not contain the tests/ directory since the .gitattributes exclude it from github zipballs. Yet the composer.json contains an autoload-dev definition which references this directory, and the binary runs a composer install (including dev) which results in a failing classmap generation.

stof · 2016-09-23T11:25:59Z

autoload-dev is taken into account only for the root project (which is not downloaded by composer, except when using create-project), so there is no reason for it to make any difference here unless a recent version of composer introduced a bug. what is your composer version ?

nicolas-grekas · 2016-09-23T11:37:27Z

Did you try deleting the .phpunit/ folder then try again?

alcohol · 2016-09-23T11:39:36Z

@stof you are wrong. The composer install is run inside the extracted phpunit directory (making phpunit the root project at that moment), and directly affects the phpunit dependencies, so autoload-dev definitely is taken into account.

linaori · 2016-09-23T11:40:40Z

My version: Composer version 1.2.1 2016-09-12 11:27:19

alcohol · 2016-09-23T11:42:04Z

See https://github.com/symfony/phpunit-bridge/blob/master/bin/simple-phpunit#L46-L57 for relevant code that causes this issue.

nicolas-grekas · 2016-09-23T11:48:28Z

So, composer is throwing the exception? Can you add -vvv to the corresponding composer call?

alcohol · 2016-09-23T11:52:16Z

I already explained why. See this comment.

Symfony attempts to install the dependencies for the phpunit version it downloaded (using composer). However, the github zipball does not contain the tests directory because of the .gitattributes configuration. The install it tries though includes the dev dependencies, and thus also triggers the parsing of the autoload-dev configuration, which references the non-existant tests directory.

alcohol · 2016-09-23T11:55:56Z

Probably relevant: sebastianbergmann/phpunit#2300

nicolas-grekas · 2016-09-23T11:56:33Z

certainly relevant, that's the trigger of all of this :)
can you submit a PR then?

linaori · 2016-09-23T11:57:03Z

My guess is a simply mkdir for /tests would be the easiest

alcohol · 2016-09-23T11:58:29Z

Sure. On what branch should this be applied?

nicolas-grekas · 2016-09-23T12:02:23Z

the lowest impacted :)
but shouldn't composer deal with this more gracefully?

alcohol · 2016-09-23T12:06:04Z

I suppose that is debatable. Composer has always failed on this. This is not new. We could attempt to handle it more gracefully, but the problem is that a lot of users rarely read the warnings we output. And as this could effectively lead to a completely broken state of your environment, I feel a warning is inadequate.

linaori · 2016-09-23T12:06:45Z

I think the proper fix would be that composer doesn't crash on this during the construction of the class-map autoloading and give an understandable error. Composer could give a neat warning in yellow though (just like the out-of-date) so that you are at least hinted of it.

Seldaek · 2016-09-23T12:13:29Z

Going to install deps and generally mess around inside the vendor dir definitely voids the composer warranty as far as I am concerned. And besides yes as @alcohol mentioned above, people don't read warnings and then complain, that's why we fail hard on this because it is a clear misconfiguration of the package. Either make sure you create the tests dir, or install with --no-dev so that the autoload-dev is ignored, which really would be the correct option IMO as you are trying to run phpunit as far as I understand, and not develop it.

alcohol · 2016-09-23T12:16:22Z

The latter was my solution also (install --no-dev), as displayed in the patch I included earlier in this thread.

alcohol · 2016-09-23T12:28:24Z

Only applies to the master branch, none of the previous branches had this binary yet.

stampycode · 2016-09-23T12:56:04Z

This fix doesn't work for me, do I need to clear anything after I've pulled in this change?

I'm running php ./phpunit symfony

nicolas-grekas · 2016-09-23T13:26:52Z

@stampycode try deleting the .phpunit/ folder before running the command?

stampycode · 2016-09-23T13:31:03Z

@nicolas-grekas ... no dice.

alcohol · 2016-09-23T13:34:17Z

That's because it hasn't been merged yet.

nicolas-grekas · 2016-09-23T13:34:19Z

OK, that's because the simple-phpunit that is used is the one in vendor/symfony/phpunit-bridge/bin/simple-phpunit, not in src/...

stampycode · 2016-09-23T13:35:58Z

@alcohol I applied the fix manually.

alcohol · 2016-09-23T13:36:37Z

Yes but to what? ;-)

stampycode · 2016-09-23T13:38:24Z

@alcohol - lol, as in #20034 - I did exactly what it said, to the file described in the PR. I'm not new to this game ;)

alcohol · 2016-09-23T13:39:18Z

To which file? Did you read the comment from @nicolas-grekas above?

stampycode · 2016-09-23T13:44:11Z

Yeah I did - but as far as I'm concerned, I'm running the unit tests as described in the documentation - if that doesn't work, then that means either the documentation is wrong, or the tests are still broken...

And yes, I've deleted the .phpunit dir between runs.

stampycode · 2016-09-23T13:46:38Z

Urgh. Ok it just started working... fml.

This PR was merged into the 3.2-dev branch. Discussion ---------- fix composer install process, resolves #20032 | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20032 | License | MIT | Doc PR | reference to the documentation PR, if any Commits ------- f418cb8 fix composer install process, resolves #20032

pkrupald024 · 2018-12-18T06:17:58Z

Did you try deleting the .phpunit/ folder then try again?

Thanks

stampycode mentioned this issue Sep 23, 2016

[HttpKernel] enabled cache-reloading when cache file is rebuilt #20033

Closed

alcohol mentioned this issue Sep 23, 2016

fix composer install process, resolves #20032 #20034

Merged

fabpot closed this as completed in f418cb8 Sep 23, 2016

linaori mentioned this issue Sep 26, 2016

[Suggestion] Adding .gitattributes to ignore unnecessary folders and files for production env #20057

Closed

stampycode mentioned this issue Sep 27, 2016

[HttpKernel] enabling cache-reloading when cache file is rebuilt #20065

Closed

fabpot mentioned this issue Oct 27, 2016

Release v3.2.0-BETA1 #20317

Merged

This comment was marked as spam.

Sign in to view

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Broken tests in master: Could not scan for classes inside "tests/" #20032

Broken tests in master: Could not scan for classes inside "tests/" #20032

This comment was marked as spam.

Broken tests in master: Could not scan for classes inside "tests/" #20032

Broken tests in master: Could not scan for classes inside "tests/" #20032

Comments

This comment was marked as spam.