8000 Invalid Yaml accepted · Issue #19436 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Invalid Yaml accepted #19436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicolas-grekas opened this issue Jul 26, 2016 · 4 comments
Closed

Invalid Yaml accepted #19436

nicolas-grekas opened this issue Jul 26, 2016 · 4 comments
Labels
Bug Status: Reviewed Yaml

Comments

@nicolas-grekas
Copy link
Member
nicolas-grekas commented Jul 26, 2016 •
edited
Loading

{1:""} is invalid yaml, but our parser accepts it.
It should be {1: ""} (space after :)
@stof stof added the Yaml label Jul 26, 2016
@stof
Copy link
Member
stof commented Jul 26, 2016

how does it parse it currently ?

@nicolas-grekas
Copy link
Member Author 
Array (
    1 => ''
)

@xabbuh xabbuh added the Bug label Jul 26, 2016
@xabbuh
Copy link
Member
xabbuh commented Jul 26, 2016

I'll look into it.

@xabbuh xabbuh mentioned this issue Jul 29, 2016
Closed
@xabbuh
Copy link
Member
xabbuh commented Jul 29, 2016

see #19472

@xabbuh xabbuh mentioned this issue Aug 2, 2016
Merged
fabpot added a commit that referenced this issue Aug 2, 2016
@fabpot
feature #19504 [Yaml] deprecate missing space after mapping key colon…
e408b50 
… (xabbuh)

This PR was merged into the 3.2-dev branch.

Discussion
----------

[Yaml] deprecate missing space after mapping key colon

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #19436, #19472
| License       | MIT
| Doc PR        |

Commits
-------

9a31eef deprecate missing space after mapping key colon
@fabpot fabpot closed this as completed Aug 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Status: Reviewed Yaml
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@fabpot @javiereguiluz @nicolas-grekas @stof @xabbuh @carsonbot
0