8000 [HttpFoundation] Refactor the Request / Response classes to use the standard interfaces from php-fig · Issue #17392 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpFoundation] Refactor the Request / Response classes to use the standard interfaces from php-fig #17392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
GuilhemN opened this issue Jan 15, 2016 · 3 comments
Closed

[HttpFoundation] Refactor the Request / Response classes to use the standard interfaces from php-fig #17392

GuilhemN opened this issue Jan 15, 2016 · 3 comments

Comments

@GuilhemN
Copy link
Contributor

As discussed here, it may be the time to think about refactoring the Request and the Response classes to follow the php-fig standards.

You can see this interfaces here.

Message from @iltar:

Actually, I've been thinking of converting the current Request/Response objects to builders. Parameter converters etc are all working by setting values and the same goes for response listeners. By converting the ResponseBuilder and RequestBuilder into a "frozen" variant, it can also be compliant with PSR. This means that when modifying the request > builder but your action > PSR request. Same goes for the response, you can return a Response(Builder), which gets converted to a PSR Response if not already.
@GuilhemN GuilhemN mentioned this issue Jan 15, 2016
Closed
@Tobion
Copy link
Contributor
Tobion commented Jan 15, 2016

Duplicate of #15414. And this has been discussed alot already. PSR-7 is immutable whereas symfonys Request/Response isn't.

@stof
Copy link
Member
stof 8000 commented Jan 15, 2016

This is impossible without creating a new incompatible framework (even though you keep the name, which only makes things harder).
Just look at closed issues talking about PSR-7 and at the Symfony blog (even though some of the discussion also happened privately in the core team, I think we posted our conclusions publicly).

this is why we have a PSR-7 bridge allowing to convert between PSR-7 and HttpFoundation instead.

@GuilhemN
Copy link
Contributor Author

@Tobion @stof right sorry I didn't see this issues...

To be closed then.

@xabbuh xabbuh mentioned this issue Jan 15, 2016
Closed
@chillu chillu mentioned this issue May 31, 2017
Open
@wouterj wouterj mentioned this issue Apr 14, 2023
Closed
@aidan-casey aidan-casey mentioned this issue Mar 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stof @Tobion @GuilhemN
0