[Form][2.8.1] entry_options are not passed to sub forms #17361

steevanb · 2016-01-14T08:54:09Z

In Symfony\Component\Form\Extension\Core\Type\CollectionType::buildForm(), $options['entry_options'] where merged un final $options variable. But in 2.8.1, this key is not merged, so all entry_options specified in FormType are not passed to sub forms.

Old code (2.8.0) :

if ($options['allow_add'] && $options['prototype']) {
    $prototype = $builder->create($options['prototype_name'], $options['entry_type'], array_replace(array(
        'label' => $options['prototype_name'].'label__',
    ), $options['entry_options'], array(
        'data' => $options['prototype_data'],
    )));
    $builder->setAttribute('prototype', $prototype->getForm());
}

New code (2.8.1), at line 5, $options['options'] is used but it's $options['entry_options'] instead :

if ($options['allow_add'] && $options['prototype']) {
    $prototypeOptions = array_replace(array(
        'required' => $options['required'],
        'label' => $options['prototype_name'].'label__',
    ), $options['options']);

    if (null !== $options['prototype_data']) {
        $prototypeOptions['data'] = $options['prototype_data'];
    }

    $prototype = $builder->create($options['prototype_name'], $options['entry_type'], $prototypeOptions);
    $builder->setAttribute('prototype', $prototype->getForm());
}

How to reproduce it :
Create a simple FormType, with a collection field, and add entry_options in third parameter of $builder->add()
This array won't be merged in 2.8.1, then change $options['options'] to $options['entry_options'] and it will works.

xabbuh · 2016-01-14T10:02:12Z

This is already fixed by #17162 and will be part of the 2.8.2 release.

xabbuh closed this as completed Jan 14, 2016

xabbuh added the Form label Jan 14, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[Form][2.8.1] entry_options are not passed to sub forms #17361

[Form][2.8.1] entry_options are not passed to sub forms #17361

Uh oh!

Uh oh!

[Form][2.8.1] entry_options are not passed to sub forms #17361

[Form][2.8.1] entry_options are not passed to sub forms #17361

Comments

Uh oh!