8000 [VarDumper] inline dumps break response and request missing from profiler · Issue #17043 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content
[VarDumper] inline dumps break response and request missing from profiler #17043
Closed
@teohhanhui

Description

@teohhanhui

Continuing the discussion from #14608...

A quick recap of the situation so far:
#14478 introduced inline dumps. This breaks the response when the response content type is not plain text or HTML (e.g. JSON).
#14609 alleviated the probem somewhat, by suppressing the inline dumps when the request can be detected as XHR (X-Requested-With header) or CORS (Origin header).
#14640 added the debug.dump_destination configuration option, which made it possible to unconditionally suppress inline dumps (usually per environment). This is not ideal as it also affects the CLI and HTML output.

There is also the greater issue that the request becomes entirely missing from the profiler when an inline dump is done inappropriately... I'd argue that this should never be allowed to happen, regardless of what we choose to do about such inappropriate inline dumps.

Suggestions:

  • Perhaps add an argument to dump to suppress inline dump.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0