8000 [Http Foundation] BinaryFileResponse should try to match "If-Range" header with file's MTime · Issue #16376 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content
[Http Foundation] BinaryFileResponse should try to match "If-Range" header with file's MTime #16376
Closed
@morille

Description

@morille

In BinaryFilesResponse.php's "prepare" method, the partial response is created only if no "If-Range" request header found, or if it matches the response's ETag.
Default behavior of this response is to not send ETag header, but Last-Modified, so we have no browser cache.
As per the spec, "If-Range" request header value may also be compared with the response's Last-Modified time.
And that would be usefull :-)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0