8000 Add Stopwatch integration for Twig when Templating component is not enabled · Issue #15785 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Add Stopwatch integration for Twig when Templating component is not enabled #15785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Koc opened this issue Sep 14, 2015 · 5 comments
Closed

Add Stopwatch integration for Twig when Templating component is not enabled #15785

Koc opened this issue Sep 14, 2015 · 5 comments
Labels
TwigBundle

Comments

@Koc
Copy link
Contributor
Koc commented Sep 14, 2015

ref #15502 (comment)
@stof
Copy link
Member
stof commented Sep 14, 2015

The way to implement this in Twig would be similar to the builtin Twig profiler: hooking in before and after nodes of the twig template, which were added for the profiler.

@fabpot
Copy link
Member
fabpot commented Sep 14, 2015

Is it really needed now that we have the Twig profiler?

@stof
Copy link
Member
stof commented Sep 14, 2015

@fabpot The Symfony timeline shows other things, for instance Doctrine queries. Being able to see that these queries happen during the rendering of a template is very handy.
The Twig profiling allows to see more details than what we can put in the timeline (putting all blocks in the timeline would be insane), but it does not combine well with other things.

@fabpot
Copy link
Member
fabpot commented Sep 14, 2015

The Twig profiler already put Twig template rendering in the timeline.

@stof
Copy link
Member
stof commented Sep 14, 2015

ah sorry, I forgot about the special ProfilerExtension available in the Symfony bridge. then my comment in #15502 was wrong and this can indeed be closed.

@stof stof closed this as completed Sep 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
TwigBundle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fabpot @Koc @stof
0