8000 [DependencyInjection][3.0] Add initialized() to the ContainerInterface · Issue #15346 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DependencyInjection][3.0] Add initialized() to the ContainerInterface #15346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
znerol opened this issue Jul 23, 2015 · 3 comments
Closed

[DependencyInjection][3.0] Add initialized() to the ContainerInterface #15346

znerol opened this issue Jul 23, 2015 · 3 comments
Labels
DependencyInjection

Comments

@znerol
Copy link
Contributor
znerol commented Jul 23, 2015

The initialized() method has been added to the container in order to check whether a service is already initialized quite late during Symfony 2 development (#3557). In order to prevent a BC break a new interface was added (IntrospectableContainerInterface).

Let's clean that up in 3.0 and move initialized() to the ContainerInterface and drop IntrospectableContainerInterface.
@znerol znerol mentioned this issue Jul 23, 2015
Closed
znerol added a commit to znerol-forks/symfony that referenced this issue Jul 23, 2015
@znerol
Fixes symfony#15346
4e2f183
@znerol znerol mentioned this issue Jul 23, 2015
Merged
@stof
Copy link
Member
stof commented Jul 23, 2015

Dropping IntrospectableContainerInterface in 3.0 would mean that it is harder to write code compatible with both 2.8 and 3.0 and wanting to know whether it can introspect the container.
Should we drop it in 3.0 or no ?

@stof
Copy link
Member
stof commented Jul 23, 2015

The issue here is that the interface cannot be deprecated in 2.x, so it would mean it is a removal without deprecation, which is bad for the upgrade.

I suggest keeping the interface (with no extra method in it) in 3.x but deprecating it.

@znerol
Copy link
Contributor Author
znerol commented Jul 26, 2015

Fine, PR updated.

fabpot added a commit that referenced this issue Jul 26, 2015
@fabpot
feature #15347 [DependencyInjection][3.0] Add initialized to containe…
23919ab 
…r interface (znerol)

This PR was merged into the 3.0-dev branch.

Discussion
----------

[DependencyInjection][3.0] Add initialized to container interface

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #15346
| License       | MIT
| Doc PR        | -

Commits
-------

bfddac3 [DependencyInjection] Add initialized() to the ContainerInterface
@fabpot fabpot closed this as completed Jul 26, 2015
@Tobion Tobion mentioned this issue Sep 4, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DependencyInjection
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@znerol @fabpot @stof @xabbuh
0