-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[DX] Minor improvement for the translation:debug output #13874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I don't have a preference, but if we proceed "equal" should be "same". |
@jakzal thanks. I've replaced |
I'm not sure if same is easy to understand if you don't know the context. What about something like "not modified" or "not adapted"? |
Either "not modified" nor "not adapted" are correct. The message is set to the same value as the fallback message, no? |
How about "fallback"? |
Yes, but this may indicate that you copied the translation file for the fallback language and forgot to translate one if the values. I have to any that this is not the only reason this happens though. |
"fallback" sounds good. "default" could also be an option. |
👍 |
Let's recap this proposal: 1) If Symfony deciders don't like this idea, please close this issue as won't fix. Thanks. 2) If the idea is accepted, let's tag it as Easy Pick, because this is the ideal issue for someone who wants to submit his/her first pull request to Symfony. The work to do is to replace the bottom "icon" legend by text labels inside the table:
Labels are color-coded as follows:
|
I agree it would be easier to understand. I vote for tagging as Easy-pick |
I added an explicit-state optional argument. The reason: we have some bash scripts that run |
@skafandri Does it make sense to add a dedicated format for such parsers (like XML or YAML)? |
@xabbuh Absolutely, the problem is that this command (among others) doesn't support the |
@skafandri I understand that you need to maintain the old behavior of the command for BC reasons. But introducing an option just to tweak the output of the command looks wrong to me. What about postponing these changes for Symfony 3.0? |
@javiereguiluz If this will be postponed to Symfony 3.0 then I would not be happy with this change because what I did here is kind of hackish :) |
…(nicolasdewez) This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #14473). Discussion ---------- [DX] Minor improvement for the translation:debug output | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #13874 Commits ------- 6970469 Changed output for translation:debug command
…t (nicolasdewez) This PR was submitted for the master branch but it was merged into the 2.8 branch instead (closes #14473). Discussion ---------- [DX] Minor improvement for the translation:debug output | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #13874 Commits ------- b941bd3 Changed output for translation:debug command
Currently,
translation:debug
output uses a legend to show the state of each translation. Example:I find the legend confusing when the table is very long, which is usually the case. Moreover, the
State
column is wide enough to not use a legend and just display the labels.That's why I propose to change this table a bit to look as follows:
The text was updated successfully, but these errors were encountered: