8000 Test failing in TwigBundle · Issue #12646 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Test failing in TwigBundle #12646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
arnaugm opened this issue Nov 29, 2014 · 2 comments
Closed

Test failing in TwigBundle #12646

arnaugm opened this issue Nov 29, 2014 · 2 comments

Comments

@arnaugm
Copy link
arnaugm commented Nov 29, 2014

Running

phpunit src/Symfony/Bundle/TwigBundle

I got the error

There were 2 errors:

1) Symfony\Bundle\TwigBundle\Tests\Controller\ExceptionControllerTest::testShowActionCanBeForcedToShowErrorPage
ob_end_clean(): failed to delete buffer. No buffer to delete


2) Symfony\Bundle\TwigBundle\Tests\Controller\ExceptionControllerTest::testFallbackToHtmlIfNoTemplateForRequestedFormat
ob_end_clean(): failed to delete buffer. No buffer to delete

Symfony branch: 2.7
OS: Ubuntu 14.04.1 LTS
PHP: 5.5.9-1ubuntu4.5
PHPUnit: 3.7.20
@xabbuh
Copy link
Member
xabbuh commented Dec 1, 2014

@arnaugm Is this even an issue for you when using PHPUnit 4.2 or higher?

@arnaugm
Copy link
Author
arnaugm commented Dec 3, 2014

The tests pass but marked as risky, not sure that's the expected behavior.

PHPUnit 4.3.5 by Sebastian Bergmann.

Configuration read from /home/arnau/code/symfony/phpunit.xml.dist

.RR....................................

Time: 213 ms, Memory: 14.25Mb

OK, but incomplete, skipped, or risky tests!
Tests: 39, Assertions: 148, Risky: 2.

@xabbuh xabbuh mentioned this issue Dec 8, 2014
Merged
fabpot added a commit that referenced this issue Dec 11, 2014
@fabpot
minor #12903 [TwigBundle] avoid risky tests (xabbuh)
c2fc7c9 
This PR was merged into the 2.6 branch.

Discussion
----------

[TwigBundle] avoid risky tests

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #12646
| License       | MIT
| Doc PR        |

Commits
-------

e7b0b89 avoid risky tests
@fabpot fabpot closed this as completed Dec 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fabpot @arnaugm @xabbuh
0