8000 Route with default value for query string param causes param to get eaten · Issue #10940 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Route with default value for query string param causes param to get eaten #10940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nickshanks opened this issue May 19, 2014 · 2 comments
Closed

Route with default value for query string param causes param to get eaten #10940

nickshanks opened this issue May 19, 2014 · 2 comments
Labels
Bug Routing Status: Needs Review

Comments

@nickshanks
Copy link

Given a route like this:

book:
    path: /book
    defaults:
        page: 1

I would expect generate('book', {'page': $page}) to generate these routes:

  1. /book when $page == 1
  2. /book?page=2 when $page == 2

What actually happens is that when a parameter has a default value, but is not present in the route path, it just gets eaten by Symfony. Both of the above values for $page result in the path /page being generated.
@Tobion
Copy link
Contributor
Tobion commented May 19, 2014

This was "fixed" but got reverted because of BC break. See #7458 and #5410

@nickshanks
Copy link
Author

I had seen #5410 but not #7458 which is probably the more important PR from my point of view. Did the "fix the documentation" issue get addressed? I saw nothing that addressed this known bug (i.e. inconsistent behaviour that can't be fixed for legacy reasons).

The other option is to introduce a new function (say, make()) that does preserve query string arguments even when they have a default value. There are a few more possibilities too.

@Tobion Tobion mentioned this issue Mar 13, 2016
Closed
@jakzal jakzal mentioned this issue Mar 14, 2016
Closed
This was referenced Mar 23, 2016
Closed
Merged
fabpot added a commit that referenced this issue Apr 15, 2016
@fabpot
bug #18280 [Routing] add query param if value is different from defau…
2528ec4 
…lt (Tobion)

This PR was merged into the 2.3 branch.

Discussion
----------

[Routing] add query param if value is different from default

| Q             | A
| ------------- | ---
| Branch?       | 2.3
| Bug fix?      | yes
| New feature?  | yes
| BC breaks?    | most likely not
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets | #10940, #18111, #18035
| License       | MIT
| Doc PR        | -

Commits
-------

1ef2edf [Routing] add query param if value is different from default
@fabpot fabpot closed this as completed Apr 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Routing Status: Needs Review 3F7B
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@fabpot @javiereguiluz @nickshanks @Tobion @carsonbot
0