10000 Extract the class resolving logic out of the controller resolver · Issue #10529 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

Extract the class resolving logic out of the controller resolver #10529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dawehner opened this issue Mar 25, 2014 · 8 comments
Closed

Extract the class resolving logic out of the controller resolver #10529

dawehner opened this issue Mar 25, 2014 · 8 comments

Comments

@dawehner
Copy link
Contributor

It would be kinda cool to move the class resolving logic (class name vs. service)
and make it available in other places

https://drupal.org/node/2165475 has such a class, which certainly would be different for symfony.

Is this a doable thing in the first place?

@cordoval
Copy link
Contributor

@dawehner did you try doing this https://github.com/igorw/doucheswag/blob/master/src/DoucheWeb/ControllerResolver.php#L9 ? @davedevelopment and @igorw did this and I think it could just as well apply here in this case.

@cordoval
Copy link
Contributor

if this satisfies our custom Drupal controller resolver then let's close the issue as well 😊

@dawehner
Copy link
Contributor Author

Well, the usecase here is to be independent from a $request object, as well as being indepent from methods, so for example "Foo\bar\Baz" could be resolved for itself.

@cordoval
Copy link
Contributor

for that couldn't you just refactor the logic into another class and then have the main class still implement the interface and just inject the logic'er into this main class? Maybe what you mean is to have symfony do that, but not your code.

@dawehner
Copy link
Contributor Author

Sure, this is exactly was https://drupal.org/node/2165475 was doing. This issue was more about asking for a similar feature in symfony itself.

@cordoval
Copy link
Contributor

ping @jakzal could you please label it with 'feature request' or what fits?

@TomasVotruba
Copy link
Contributor

This seems like a good feature proposal. Since Symfony components are integrated in Drupal 8, it would make even more sense.

What needs to be done here?

@fabpot
Copy link
Member
fabpot commented Oct 10, 2018

Closing as it seems that the linked issue on Drupal has been resolved.

@fabpot fabpot closed this as completed Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants
0