-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Extract the class resolving logic out of the controller resolver #10529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@dawehner did you try doing this https://github.com/igorw/doucheswag/blob/master/src/DoucheWeb/ControllerResolver.php#L9 ? @davedevelopment and @igorw did this and I think it could just as well apply here in this case. |
if this satisfies our custom Drupal controller resolver then let's close the issue as well 😊 |
Well, the usecase here is to be independent from a $request object, as well as being indepent from methods, so for example "Foo\bar\Baz" could be resolved for itself. |
for that couldn't you just refactor the logic into another class and then have the main class still implement the interface and just inject the logic'er into this main class? Maybe what you mean is to have symfony do that, but not your code. |
Sure, this is exactly was https://drupal.org/node/2165475 was doing. This issue was more about asking for a similar feature in symfony itself. |
ping @jakzal could you please label it with 'feature request' or what fits? |
This seems like a good feature proposal. Since Symfony components are integrated in Drupal 8, it would make even more sense. What needs to be done here? |
Closing as it seems that the linked issue on Drupal has been resolved. |
It would be kinda cool to move the class resolving logic (class name vs. service)
and make it available in other places
https://drupal.org/node/2165475 has such a class, which certainly would be different for symfony.
Is this a doable thing in the first place?
The text was updated successfully, but these errors were encountered: