8000 AppEngine Support for File Uploading · Issue #10510 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

AppEngine Support for File Uploading #10510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ircmaxell opened this issue Mar 21, 2014 · 3 comments
Closed

AppEngine Support for File Uploading #10510

ircmaxell opened this issue Mar 21, 2014 · 3 comments
Labels
HttpFoundation

Comments

@ircmaxell
Copy link
Contributor

Currently, the upload file handler in request bails on AppEngine because of the ini_get('file_uploads') check in the handler:

https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpFoundation/File/UploadedFile.php#L94

Since GAE is patched to side-channel insert this data, it bypasses PHP's built in file uploading functionality (and intentionally disables it). However, the code as it exists currently make a (perhaps superfluous) check to ini_get()...

I am suggesting that the entire if statement is removed, as the only case it would actually prevent from happening is if a user fakes the $_FILE array on a server that has uploads disabled...

I can verify that file uploads work correctly on GAE if you remove this line.

I can raise a PR for the 3 line change, but I figured I'd start off with a discussion first...
@jakzal
Copy link
Contributor
jakzal commented Mar 22, 2014

duplicates #9945
re #9238 #9442

@micheleorselli
Copy link
Contributor

This was proposed in #9784. Let's see if Fabien changed is mind :-)

@ircmaxell
Copy link
Contributor Author

Closing this in preference to #9945, as it is an exact duplicate...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
HttpFoundation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@micheleorselli @jakzal @ircmaxell
0