8000 Symfony\Component\Console\Helper\Table::addRow throws undefined Exception · Issue #10464 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Symfony\Component\Console\Helper\Table::addRow throws undefined Exception #10464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
insekticid opened this issue Mar 17, 2014 · 2 comments
Closed

Symfony\Component\Console\Helper\Table::addRow throws undefined Exception #10464

insekticid opened this issue Mar 17, 2014 · 2 comments

Comments

@insekticid
Copy link
Contributor

https://github.com/symfony/Console/blob/master/Helper/Table.php#L170

InvalidArgumentException

        if (!is_array($row)) {
            throw new InvalidArgumentException('A row must be an array or a TableSeparator instance.');
        }

instead of

        if (!is_array($row)) {
            throw new \InvalidArgumentException('A row must be an array or a TableSeparator instance.');
        }
@stof
Copy link
Member
stof commented Mar 17, 2014

Can you send a pull request with the fix ? This way, you will get the authorship of the commit

@cordoval cordoval mentioned this issue Mar 17, 2014
Merged
@cordoval
Copy link
Contributor

@insekticid I did another correction on the same class. If you want me to split this into 2 commits I can and use the git author flag to attribute you the authorship but i would need your consent first.

fabpot added a commit that referenced this issue Mar 17, 2014
@fabpot
minor #10469 fix doc block and namespace by @insekticide (cordoval)
c152ccb 
This PR was merged into the 2.5-dev branch.

Discussion
----------

fix doc block and namespace by @insekticide

|Q            |A     |
|---          |---   |
|Bug Fix?     |yes   |
|New Feature? |no    |
|BC Breaks?   |no    |
|Deprecations?|no    |
|Tests Pass?  |yes   |
|Fixed Tickets|#10464|
|License      |MIT   |
|Doc PR       |      |

Commits
-------

89bde6e fix class namespace by @insekticid and doc block fix
@fabpot fabpot closed this as completed Mar 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fabpot @insekticid @cordoval @stof
0