8000 [FrameworkBundle][Console] container:debug --parameter="" not working anymore · Issue #10345 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle][Console] container:debug --parameter="" not working anymore #10345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ruudk opened this issue Feb 27, 2014 · 7 comments
Closed

[FrameworkBundle][Console] container:debug --parameter="" not working anymore #10345

ruudk opened this issue Feb 27, 2014 · 7 comments
Labels
Console

Comments

@ruudk
Copy link
Contributor
ruudk commented Feb 27, 2014

With container:debug --parameter="database_name" you can retreive the value of a parameter. This worked in 2.3.9 perfectly. But in 2.4.0 (and up) it doesn't work anymore.

Steps to reproduce:

git clone git@github.com:symfony/symfony-standard.git .
git checkout v2.4.2
composer install

This works great:

$ php app/console container:debug --parameters | grep database_name
database_name             symfony

But this doesn't return anything:

$ php app/console container:debug --parameter=database_name
@cordoval
Copy link
Contributor

please provide the error you get, thanks

@ruudk
Copy link
Contributor Author
ruudk commented Feb 27, 2014

There is no error, it doesn't print anything :)

@cordoval
Copy link
Contributor

yeah i just saw it 👶 👍 good catch

@stof
Copy link
Member
stof commented Feb 27, 2014

The issue is that the Descriptor implementation is broken at https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/Descriptor.php#L58
It does not write anything to the output

/cc @jfsimon

@cordoval
Copy link
Contributor

@inalgnu good opportunity to raise code coverage here

@FineWolf FineWolf mentioned this issue Mar 2, 2014
Closed
2 tasks
@ruudk ruudk added the Console label Mar 3, 2014
@inelgnu
Copy link
Contributor
inelgnu commented Mar 3, 2014

@cordoval ^^ i'm on it ! or @FineWolf is already writing tests?

@saro0h
Copy link
Contributor
saro0h commented Mar 3, 2014

👍

@inelgnu inelgnu mentioned this issue Mar 3, 2014
Closed
fabpot pushed a commit that referenced this issue Mar 26, 2014
@FineWolf @fabpot
Fix issue #10345 '[FrameworkBundle][Console] container:debug --parame…
b278aa4 
…ter="" not working anymore'
fabpot added a commit that referenced this issue Mar 26, 2014
@fabpot
bug #10363 [FrameworkBundle][Console] Fix issue #10345 container:debu…
69fa1da 
…g --parameter="" not working anymore (FineWolf)

This PR was merged into the 2.4 branch.

Discussion
----------

[FrameworkBundle][Console] Fix issue #10345 container:debug --parameter="" not working anymore

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes*
| Fixed tickets | #10345
| License       | MIT
| Doc PR        | N/A

## TODO
- [x] Fix issue #10345
- [ ] Create unit test for `describeContainerParameter`

Commits
-------

b278aa4 Fix issue #10345 '[FrameworkBundle][Console] container:debug --parameter="" not working anymore'
@fabpot fabpot closed this as completed Mar 26, 2014
fabpot pushed a commit to symfony/framework-bundle that referenced this issue Mar 26, 2014
@FineWolf @fabpot
Fix issue symfony/symfony#10345 '[FrameworkBundle][Console] container…
1e654ae 
…:debug --parameter="" not working anymore'
fabpot added a commit that referenced this issue Mar 26, 2014
@fabpot
Merge branch '2.4'
e0de958 
* 2.4:
  Check headers sent before sending PHP response
  Fix issue #10345 '[FrameworkBundle][Console] container:debug --parameter="" not working anymore'
  Fixed ACE domain checks on UrlValidator (#10031)
  handle array root element
fabpot added a commit to symfony/debug that referenced this issue Mar 26, 2014
@fabpot
Merge branch '2.4'
5eec1e0 
* 2.4:
  Check headers sent before sending PHP response
  Fix issue symfony/symfony#10345 '[FrameworkBundle][Console] container:debug --parameter="" not working anymore'
  Fixed ACE domain checks on UrlValidator (#10031)
  handle array root element
fabpot added a commit to symfony/validator that referenced this issue Mar 26, 2014
@fabpot
Merge branch '2.4'
3b52f4b 
* 2.4:
  Check headers sent before sending PHP response
  Fix issue symfony/symfony#10345 '[FrameworkBundle][Console] container:debug --parameter="" not working anymore'
  Fixed ACE domain checks on UrlValidator (#10031)
  handle array root element
fabpot added a commit to symfony/framework-bundle that referenced this issue Mar 26, 2014
@fabpot
Merge branch '2.4'
9e57b57 
* 2.4:
  Check headers sent before sending PHP response
  Fix issue symfony/symfony#10345 '[FrameworkBundle][Console] container:debug --parameter="" not working anymore'
  Fixed ACE domain checks on UrlValidator (#10031)
  handle array root element
fabpot added a commit that referenced this issue Mar 27, 2014
@fabpot
feature #10370 [FrameworkBundle][Console] Add parameter descriptors (…
e505ecd 
…inalgnu)

This PR was squashed before being merged into the 2.5-dev branch (closes #10370).

Discussion
----------

[FrameworkBundle][Console] Add parameter descriptors

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #10345
| License       | MIT
| Doc PR        | n/a

I've added several descriptors for each format, henceforth :
``php app/console container:debug --parameter=database_name --format=txt`` will output:
``symfony``

``php app/console container:debug --parameter=database_name --format=json`` will output:
```json
{
    "database_name": "symfony"
}
```

``php app/console container:debug --parameter=database_name --format=xml`` will output :
```xml
<?xml version="1.0" encoding="UTF-8"?>
<parameter key="database_name">symfony</parameter>
```
and ``php app/console container:debug --parameter=database_name --format=md`` will output :
```md
database_name
=============

symfony
```

what do you think ?

Commits
-------

6aa1050 Add parameter descriptors
fabpot added a commit to fabpot/symfony that referenced this issue Mar 30, 2014
@fabpot
Merge branch 'master' into container-optim
d4fca74 
* master: (202 commits)
  fixed CS
  added missing unit test
  framework_bundle -> framework
  Add parameter descriptors
  fixed too greedy replacements
  fixed protocol-relative URLs
  added override power to server parameters provided on request method
  Add command to list twig functions, filters, globals and tests
  made parsing controllers more robust
  Improved ISBN validator
  fixed CS
  Move normalizer cache to getNormalier()/getDenormalizer(), use those in normalizeObject()/denormalizeObject()
  Fixed YamlFileLoader imports path
  symfony#1581 - Strict in Email constraint and use of Egulias\EmailValidator
  Check headers sent before sending PHP response
  Add UnprocessableEntityHttpException to HttpKernel Exceptions
  Fix issue symfony#10345 '[FrameworkBundle][Console] container:debug --parameter="" not working anymore'
  Added new validator for UUIDs
  Fixed ACE domain checks on UrlValidator (symfony#10031)
  handle array root element
  ...
fabpot pushed a commit to symfony/framework-bundle that referenced this issue Nov 11, 2014
@FineWolf @fabpot
Fix issue symfony/symfony#10345 '[FrameworkBundle][Console] container…
7840fe5 
…:debug --parameter="" not working anymore'
fabpot added a commit to symfony/framework-bundle that referenced this issue Nov 11, 2014
@fabpot
Merge branch '2.4'
343e6a4 
* 2.4:
  Check headers sent before sending PHP response
  Fix issue symfony/symfony#10345 '[FrameworkBundle][Console] container:debug --parameter="" not working anymore'
  Fixed ACE domain checks on UrlValidator (#10031)
  handle array root element
fago pushed a commit to fago/Validator that referenced this issue Apr 18, 2015
@fabpot
Merge branch '2.4'
d44b016 
* 2.4:
  Check headers sent before sending PHP response
  Fix issue symfony/symfony#10345 '[FrameworkBundle][Console] container:debug --parameter="" not working anymore'
  Fixed ACE domain checks on UrlValidator (#10031)
  handle array root element
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Console
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@fabpot @ruudk @cordoval @stof @inelgnu @saro0h
0