bug #38095 [Mailer] Remove unnecessary check for existing request (jschaedl)

fabpot · fabpot · commit fff8c001e628 · 2020-09-07T17:29:19.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- [Mailer] Remove unnecessary check for existing request | Q | A | ------------- | --- | Branch? | 4.4  | Bug fix? | yes | New feature? | no  | Deprecations? | no  | Tickets | Fix #38035  | License | MIT | Doc PR | -   Commits ------- 3feff72 remove unnecessary check for existing request
diff --git a/src/Symfony/Bundle/FrameworkBundle/Test/MailerAssertionsTrait.php b/src/Symfony/Bundle/FrameworkBundle/Test/MailerAssertionsTrait.php
@@ -118,10 +118,6 @@ public static function getMailerMessage(int $index = 0, string $transport = null
 
     private static function getMessageMailerEvents(): MessageEvents
     {
-        if (!self::getClient()->getRequest()) {
-            static::fail('Unable to make email assertions. Did you forget to make an HTTP request?');
-        }
-
         if (!self::$container->has('mailer.logger_message_listener')) {
             static::fail('A client must have Mailer enabled to make email assertions. Did you forget to require symfony/mailer?');
         }

Original file line number	Diff line number	Diff line change
`@@ -118,10 +118,6 @@ public static function getMailerMessage(int $index = 0, string $transport = null`
`118`	`118`
`119`	`119`	`private static function getMessageMailerEvents(): MessageEvents`
`120`	`120`	`{`
`121`		`- if (!self::getClient()->getRequest()) {`
`122`		`- static::fail('Unable to make email assertions. Did you forget to make an HTTP request?');`
`123`		`- }`
`124`		`-`
`125`	`121`	`if (!self::$container->has('mailer.logger_message_listener')) {`
`126`	`122`	`static::fail('A client must have Mailer enabled to make email assertions. Did you forget to require symfony/mailer?');`
`127`	`123`	`}`