bug #36259 [DomCrawler] Fix BC break in assertions breaking Panther (dunglas)

nicolas-grekas · nicolas-grekas · commit ff2c362195db · 2020-03-30T12:16:58.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- [DomCrawler] Fix BC break in assertions breaking Panther | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no  | Deprecations? | no  | Tickets | n/a | License | MIT | Doc PR | n/a #35899 introduces a BC break: browsers aren't able to retrieve the non-normalized version of a text. According to the HTML spec, whitespaces are always normalized. Because of this patch, these assertions doesn't work with Panther anymore. Also, this change probably hurts other users because getting the non-normalized version is almost never expected. (I'm in favor of **not** supporting retrieving the non-normalized version at all, for consistency with browsers and the spec, but it's another topic). Commits ------- 7af07c8 [DomCrawler] Fix BC break in assertions breaking Panther
diff --git a/src/Symfony/Component/DomCrawler/Test/Constraint/CrawlerSelectorTextContains.php b/src/Symfony/Component/DomCrawler/Test/Constraint/CrawlerSelectorTextContains.php
@@ -45,7 +45,7 @@ protected function matches($crawler): bool
             return false;
         }
 
-        return false !== mb_strpos($crawler->text(null, false), $this->expectedText);
+        return false !== mb_strpos($crawler->text(null, true), $this->expectedText);
     }
 
     /**
diff --git a/src/Symfony/Component/DomCrawler/Test/Constraint/CrawlerSelectorTextSame.php b/src/Symfony/Component/DomCrawler/Test/Constraint/CrawlerSelectorTextSame.php
@@ -45,7 +45,7 @@ protected function matches($crawler): bool
             return false;
         }
 
-        return $this->expectedText === trim($crawler->text(null, false));
+        return $this->expectedText === trim($crawler->text(null, true));
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ protected function matches($crawler): bool`
`45`	`45`	`return false;`
`46`	`46`	`}`
`47`	`47`
`48`		`- return false !== mb_strpos($crawler->text(null, false), $this->expectedText);`
	`48`	`+ return false !== mb_strpos($crawler->text(null, true), $this->expectedText);`
`49`	`49`	`}`
`50`	`50`
`51`	`51`	`/**`