bug #30884 [Workflow] Fixed initial places when no places are configured (lyrixx)

fabpot · fabpot · commit fe7363fff145 · 2019-04-06T13:29:01.000+02:00
This PR was merged into the 4.3-dev branch. Discussion ---------- [Workflow] Fixed initial places when no places are configured | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | EUFOSSA I introduced a BC break in #30468 and this PR fix it. With the full stack framework, when one does not configure the initial_place(s) the DIC set `[]` for the initial values. So it removes the initials values guessed in `Definition::addPlace()` Commits ------- 76fd9c3 [Workflow] Fixed initial places when no places are configured
diff --git a/src/Symfony/Component/Workflow/Definition.php b/src/Symfony/Component/Workflow/Definition.php
@@ -94,7 +94,7 @@ public function getMetadataStore(): MetadataStoreInterface
 
     private function setInitialPlaces($places = null)
     {
-        if (null === $places) {
+        if (!$places) {
             return;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ public function getMetadataStore(): MetadataStoreInterface`
`94`	`94`
`95`	`95`	`private function setInitialPlaces($places = null)`
`96`	`96`	`{`
`97`		`- if (null === $places) {`
	`97`	`+ if (!$places) {`
`98`	`98`	`return;`
`99`	`99`	`}`
`100`	`100`