feature #48053 [Messenger] Improve DX (Nommyde)

fabpot · fabpot · commit fdd04c74d58c · 2022-12-02T12:55:25.000+01:00
This PR was merged into the 6.3 branch. Discussion ---------- [Messenger] Improve DX | Q | A | ------------- | --- | Branch? | 6.2  | Bug fix? | no | New feature? | no  | Deprecations? | no  | Tickets | Fix #42353  | License | MIT The PR doesn't remove the ability to delete messages because it requires too complex refactoring, but at least it makes DX more transparent and predictable. Commits ------- a9ec12a [Messenger] Improve DX
diff --git a/src/Symfony/Component/Messenger/Command/FailedMessagesRetryCommand.php b/src/Symfony/Component/Messenger/Command/FailedMessagesRetryCommand.php
@@ -176,7 +176,7 @@ private function runWorker(string $failureTransportName, ReceiverInterface $rece
                 throw new \RuntimeException(sprintf('The message with id "%s" could not decoded, it can only be shown or removed.', $this->getMessageId($envelope) ?? '?'));
             }
 
-            $shouldHandle = $shouldForce || $io->confirm('Do you want to retry (yes) or delete this message (no)?');
+            $shouldHandle = $shouldForce || 'retry' === $io->choice('Please select an action', ['retry', 'delete'], 'retry');
 
             if ($shouldHandle) {
                 return;

Original file line number	Diff line number	Diff line change
`@@ -176,7 +176,7 @@ private function runWorker(string $failureTransportName, ReceiverInterface $rece`
`176`	`176`	`throw new \RuntimeException(sprintf('The message with id "%s" could not decoded, it can only be shown or removed.', $this->getMessageId($envelope) ?? '?'));`
`177`	`177`	`}`
`178`	`178`
`179`		`- $shouldHandle = $shouldForce \|\| $io->confirm('Do you want to retry (yes) or delete this message (no)?');`
	`179`	`+ $shouldHandle = $shouldForce \|\| 'retry' === $io->choice('Please select an action', ['retry', 'delete'], 'retry');`
`180`	`180`
`181`	`181`	`if ($shouldHandle) {`
`182`	`182`	`return;`