8000 [FrameworkBundle] Deprecate setting the `collect_serializer_data` to … · symfony/symfony@fcf4b27 · GitHub
[go: up one dir, main page]
Skip to content

Commit fcf4b27

Browse files
mtarldmtarld
committed
[FrameworkBundle] Deprecate setting the collect_serializer_data to false 
1 parent f1e169e commit fcf4b27

File tree

14 files changed

+20
-56
lines changed

14 files changed

+20
-56
lines changed

‎UPGRADE-7.3.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ FrameworkBundle
5656
because its default value will change in version 8.0
5757
* Deprecate the `--show-arguments` option of the `container:debug` command, as arguments are now always shown
5858
* Deprecate the `framework.validation.cache` config option
59+
* Deprecate setting the `framework.profiler.collect_serializer_data` config option to `false`
5960

6061
Ldap
6162
----

‎src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ CHANGELOG
1919
* Add DI alias from `ServicesResetterInterface` to `services_resetter`
2020
* Add `methods` argument in `#[IsCsrfTokenValid]` attribute
2121
* Allow configuring the logging channel per type of exceptions
22+
* Deprecate setting the `framework.profiler.collect_serializer_data` config option to `false`
2223

2324
7.2
2425
---

‎src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -429,7 +429,7 @@ public function load(array $configs, ContainerBuilder $container): void
429429
}
430430
$loggers[$exception['log_channel']] = new Reference('monolog.logger.'.$exception['log_channel'], ContainerInterface::NULL_ON_INVALID_REFERENCE);
431431
}
432-
432+
433433
$exceptionListener
434434
->replaceArgument(3, $config['exceptions'])
435435
->setArgument(4, $loggers)
@@ -984,6 +984,10 @@ private function registerProfilerConfiguration(array $config, ContainerBuilder $
984984
$loader->load('notifier_debug.php');
985985
}
986986

987+
if (false === $config['collect_serializer_data']) {
988+
trigger_deprecation('symfony/framework-bundle', '7.3', 'Setting the "framework.profiler.collect_serializer_data" config option to "false" is deprecated.');
989+
}
990+
987991
if ($this->isInitializedConfigEnabled('serializer') && $config['collect_serializer_data']) {
988992
$loader->load('serializer_debug.php');
989993
}

‎src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/php/profiler.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
'php_errors' => ['log' => true],
88
'profiler' => [
99
'enabled' => true,
10+
'collect_serializer_data' => true,
1011
],
1112
'serializer' => [
1213
'enabled' => true,

‎src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/php/profiler_collect_serializer_data.php

Lines changed: 0 additions & 15 deletions
This file was deleted.

‎src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/xml/profiler.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<framework:config http-method-override="false" handle-all-throwables="true">
1010
<framework:annotations enabled="false" />
1111
<framework:php-errors log="true" />
12-
<framework:profiler enabled="true" />
12+
<framework:profiler enabled="true" collect-serializer-data="true" />
1313
<framework:serializer enabled="true" />
1414
</framework:config>
1515
</container>

‎src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/xml/profiler_collect_serializer_data.xml

Lines changed: 0 additions & 15 deletions
This file was deleted.

‎src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/yml/profiler.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,6 @@ framework:
66
log: true
77
profiler:
88
enabled: true
9+
collect_serializer_data: true
910
serializer:
1011
enabled: true

‎src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/yml/profiler_collect_serializer_data.yml

Lines changed: 0 additions & 11 deletions
This file was deleted.

‎src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTestCase.php

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -278,22 +278,13 @@ public function testDisabledProfiler()
278278

279279
public function testProfilerCollectSerializerDataEnabled()
280280
{
281-
$container = $this->createContainerFromFile('profiler_collect_serializer_data');
281+
$container = $this->createContainerFromFile('profiler');
282282

283283
$this->assertTrue($container->hasDefinition('profiler'));
284284
$this->assertTrue($container->hasDefinition('serializer.data_collector'));
285285
$this->assertTrue($container->hasDefinition('debug.serializer'));
286286
}
287287

288-
public function testProfilerCollectSerializerDataDefaultDisabled()
289-
{
290-
$container = $this->createContainerFromFile('profiler');
291-
292-
$this->assertTrue($container->hasDefinition('profiler'));
293-
$this->assertFalse($container->hasDefinition('serializer.data_collector'));
294-
$this->assertFalse($container->hasDefinition('debug.serializer'));
295-
}
296-
297288
public function testWorkflows()
298289
{
299290
$container = $this->createContainerFromFile('workflows');

‎src/Symfony/Bundle/FrameworkBundle/Tests/Functional/app/config/framework.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ framework:
1818
cookie_samesite: lax
1919
php_errors:
2020
log: true
21+
profiler:
22+
collect_serializer_data: true
2123

2224
services:
2325
logger: { class: Psr\Log\NullLogger }

‎src/Symfony/Bundle/SecurityBundle/Tests/Functional/app/FirewallEntryPoint/config.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,9 @@ framework:
1717
cookie_samesite: lax
1818
php_errors:
1919
log: true
20-
profiler: { only_exceptions: false }
20+
profiler:
21+
only_exceptions: false
22+
collect_serializer_data: true
2123

2224
services:
2325
logger: { class: Psr\Log\NullLogger }

‎src/Symfony/Bundle/SecurityBundle/Tests/Functional/app/config/framework.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,9 @@ framework:
1818
cookie_samesite: lax
1919
php_errors:
2020
log: true
21-
profiler: { only_exceptions: false }
21+
profiler:
22+
only_exceptions: false
23+
collect_serializer_data: true
2224

2325
services:
2426
logger: { class: Psr\Log\NullLogger }

‎src/Symfony/Bundle/WebProfilerBundle/Tests/Functional/WebProfilerBundleKernel.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ protected function configureContainer(ContainerBuilder $container, LoaderInterfa
5555
'http_method_override' => false,
5656
'php_errors' => ['log' => true],
5757
'secret' => 'foo-secret',
58-
'profiler' => ['only_exceptions' => false],
58+
'profiler' => ['only_exceptions' => false, 'collect_serializer_data' => true],
5959
'session' => ['handler_id' => null, 'storage_factory_id' => 'session.storage.factory.mock_file', 'cookie-secure' => 'auto', 'cookie-samesite' => 'lax'],
6060
'router' => ['utf8' => true],
6161
];

0 commit comments

Comments
 (0)
0