minor #30003 Remove unreachable code (TysonAndre)

nicolas-grekas · nicolas-grekas · commit fceb2a2de439 · 2019-01-28T19:04:02.000+01:00
This PR was submitted for the 4.2 branch but it was merged into the 4.1 branch instead (closes #30003). Discussion ---------- Remove unreachable code | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | (unreachable) | New feature? | no | BC breaks? | no  | Deprecations? | no | Tests pass? | n/a (unreachable)  | Fixed tickets | #...  | License | MIT | Doc PR | The try/finally block will either return or throw. Additionally, $socket was never defined. Detected via static analysis Commits ------- 2fb8f49 Remove unreachable code
diff --git a/src/Symfony/Component/VarDumper/Server/Connection.php b/src/Symfony/Component/VarDumper/Server/Connection.php
@@ -91,7 +91,5 @@ private function createSocket()
         } finally {
             restore_error_handler();
         }
-
-        return $socket;
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,5 @@ private function createSocket()`
`91`	`91`	`} finally {`
`92`	`92`	`restore_error_handler();`
`93`	`93`	`}`
`94`		`-`
`95`		`- return $socket;`
`96`	`94`	`}`
`97`	`95`	`}`