feature #42286 [HttpFoundation] Add SessionFactoryInterface (kbond)

fabpot · fabpot · commit fcd3a0c6f8cc · 2021-08-06T11:37:51.000+02:00
This PR was merged into the 5.4 branch. Discussion ---------- [HttpFoundation] Add `SessionFactoryInterface` | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #41443 | License | MIT | Doc PR | - Assuming `@jderusse`'s [solution](#41443 (comment)) in #41443 is the best way to add custom session bags by a 3rd party bundle, there should really be a `SessionFactoryInterface` to make decorating the `SessionFactory` easier. Commits ------- 2079eb5 add SessionFactoryInterface
diff --git a/src/Symfony/Component/HttpFoundation/Session/SessionFactory.php b/src/Symfony/Component/HttpFoundation/Session/SessionFactory.php
@@ -20,7 +20,7 @@ class_exists(Session::class);
 /**
  * @author Jérémy Derussé <jeremy@derusse.com>
  */
-class SessionFactory
+class SessionFactory implements SessionFactoryInterface
 {
     private $requestStack;
     private $storageFactory;
diff --git a/src/Symfony/Component/HttpFoundation/Session/SessionFactoryInterface.php b/src/Symfony/Component/HttpFoundation/Session/SessionFactoryInterface.php
@@ -0,0 +1,20 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\HttpFoundation\Session;
+
+/**
+ * @author Kevin Bond <kevinbond@gmail.com>
+ */
+interface SessionFactoryInterface
+{
+    public function createSession(): SessionInterface;
+}

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ class_exists(Session::class);`
`20`	`20`	`/**`
`21`	`21`	`* @author Jérémy Derussé <jeremy@derusse.com>`
`22`	`22`	`*/`
`23`		`-class SessionFactory`
	`23`	`+class SessionFactory implements SessionFactoryInterface`
`24`	`24`	`{`
`25`	`25`	`private $requestStack;`
`26`	`26`	`private $storageFactory;`