minor #60287 [VarDumper] Remove unused code (wkania)

nicolas-grekas · nicolas-grekas · commit fc40d62f66fb · 2025-05-09T16:10:42.000+02:00
This PR was merged into the 7.3 branch. Discussion ---------- [VarDumper] Remove unused code | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT Not all was removed in the [PR](#52619). I did not remove [objects](#30350). It did look like unused code. Maybe some comment in code needed? Last uses of `Cookie` and `refs` were deleted [here](https://github.com/symfony/symfony/pull/41295/files#diff-27fadd95a89adb229b33890577a4495e15bdbc1b25f12c44f7afa8a12a00d37b). Last use of $[values](ff00f8f#diff-27fadd95a89adb229b33890577a4495e15bdbc1b25f12c44f7afa8a12a00d37bR100). Commits ------- fbc4c34 [VarDumper] Remove unused code
diff --git a/src/Symfony/Component/VarDumper/Cloner/VarCloner.php b/src/Symfony/Component/VarDumper/Cloner/VarCloner.php
@@ -28,14 +28,12 @@ protected function doClone(mixed $var): array
         $objRefs = [];                  // Map of original object handles to their stub object counterpart
         $objects = [];                  // Keep a ref to objects to ensure their handle cannot be reused while cloning
         $resRefs = [];                  // Map of original resource handles to their stub object counterpart
-        $values = [];                   // Map of stub objects' ids to original values
         $maxItems = $this->maxItems;
         $maxString = $this->maxString;
         $minDepth = $this->minDepth;
         $currentDepth = 0;              // Current tree depth
         $currentDepthFinalIndex = 0;    // Final $queue index for current tree depth
         $minimumDepthReached = 0 === $minDepth; // Becomes true when minimum tree depth has been reached
-        $cookie = (object) [];          // Unique object used to detect hard references
         $a = null;                      // Array cast for nested structures
         $stub = null;                   // Stub capturing the main properties of an original item value
                                         // or null if the original value is used directly
@@ -53,7 +51,7 @@ protected function doClone(mixed $var): array
                 }
             }
 
-            $refs = $vals = $queue[$i];
+            $vals = $queue[$i];
             foreach ($vals as $k => $v) {
                 // $v is the original value or a stub object in case of hard references
 
@@ -215,10 +213,6 @@ protected function doClone(mixed $var): array
             $queue[$i] = $vals;
         }
 
-        foreach ($values as $h => $v) {
-            $hardRefs[$h] = $v;
-        }
-
         return $queue;
     }
 }
