8000 minor #33018 remove some more useless phpdocs (Tobion) · symfony/symfony@fbaf4ac · GitHub
[go: up one dir, main page]
Skip to content

Commit fbaf4ac

Browse files
nicolas-grekasnicolas-grekas
committed
minor #33018 remove some more useless phpdocs (Tobion)
This PR was merged into the 4.4 branch. Discussion ---------- remove some more useless phpdocs | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Fix some leftovers from #32974 and #32786 Commits ------- 9be4d17 remove some more useless phpdocs
2 parents b0444f2 + 9be4d17 commit fbaf4ac

File tree

5 files changed

+5
-21
lines changed

5 files changed

+5
-21
lines changed

‎src/Symfony/Component/HttpKernel/EventListener/LocaleListener.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,6 @@ class LocaleListener implements EventSubscriberInterface
3333
private $defaultLocale;
3434
private $requestStack;
3535

36-
/**
37-
* @param string $defaultLocale The default locale
38-
* @param RequestContextAwareInterface|null $router The router
39-
*/
4036
public function __construct(RequestStack $requestStack, string $defaultLocale = 'en', RequestContextAwareInterface $router = null)
4137
{
4238
$this->defaultLocale = $defaultLocale;

‎src/Symfony/Component/HttpKernel/HttpCache/HttpCache.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -456,8 +456,8 @@ protected function fetch(Request $request, $catch = false)
456456
* All backend requests (cache passes, fetches, cache validations)
457457
* run through this method.
458458
*
459-
* @param bool $catch Whether to catch exceptions or not
460-
* @param Response $entry A Response instance (the stale entry if present, null otherwise)
459+
* @param bool $catch Whether to catch exceptions or not
460+
* @param Response|null $entry A Response instance (the stale entry if present, null otherwise)
461461
*
462462
* @return Response A Response instance
463463
*/

‎src/Symfony/Component/HttpKernel/HttpKernel.php

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -174,8 +174,7 @@ private function handleRaw(Request $request, int $type = self::MASTER_REQUEST)
174174
/**
175175
* Filters a response object.
176176
*
177-
* @param Request $request An error message in case the response is not a Response object
178-
* @param int $type The type of the request (one of HttpKernelInterface::MASTER_REQUEST or HttpKernelInterface::SUB_REQUEST)
177+
* @param int $type The type of the request (one of HttpKernelInterface::MASTER_REQUEST or HttpKernelInterface::SUB_REQUEST)
179178
*
180179
* @throws \RuntimeException if the passed object is not a Response instance
181180
*/
@@ -206,8 +205,7 @@ private function finishRequest(Request $request, int $type)
206205
/**
207206
* Handles an exception by trying to convert it to a Response.
208207
*
209-
* @param \Exception $e An \Exception instance
210-
* @param int $type The type of the request (one of HttpKernelInterface::MASTER_REQUEST or HttpKernelInterface::SUB_REQUEST)
208+
* @param int $type The type of the request (one of HttpKernelInterface::MASTER_REQUEST or HttpKernelInterface::SUB_REQUEST)
211209
*
212210
* @throws \Exception
213211
*/

‎src/Symfony/Component/Intl/Data/Bundle/Writer/TextBundleWriter.php

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@
1111

1212
namespace Symfony\Component\Intl\Data\Bundle\Writer;
1313

14-
use Symfony\Component\Intl\Exception\UnexpectedTypeException;
15-
1614
/**
1715
* Writes .txt resource bundles.
1816
*
@@ -183,16 +181,9 @@ private function writeArray($file, array $value, int $indentation)
183181
* Writes a "table" node.
184182
*
185183
* @param resource $file The file handle to write to
186-
*
187-
* @throws UnexpectedTypeException when $value is not an array and not a
188-
* \Traversable instance
189184
*/
190185
private function writeTable($file, iterable $value, int $indentation, bool $fallback = true)
191186
{
192-
if (!\is_array($value) && !$value instanceof \Traversable) {
193-
throw new UnexpectedTypeException($value, 'array or \Traversable');
194-
}
195-
196187
if (!$fallback) {
197188
fwrite($file, ':table(nofallback)');
198189
}

‎src/Symfony/Component/Security/Http/Firewall/LogoutListener.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,7 @@ class LogoutListener implements ListenerInterface
4242
private $csrfTokenManager;
4343

4444
/**
45-
* @param TokenStorageInterface $tokenStorage
46-
* @param array $options An array of options to process a logout attempt
45+
* @param array $options An array of options to process a logout attempt
4746
*/
4847
public function __construct(TokenStorageInterface $tokenStorage, HttpUtils $httpUtils, LogoutSuccessHandlerInterface $successHandler, array $options = [], CsrfTokenManagerInterface $csrfTokenManager = null)
4948
{

0 commit comments

Comments
 (0)
0