bug #36899 [VarDumper] ReflectionFunction::isDisabled() is deprecated (derrabus)

nicolas-grekas · nicolas-grekas · commit fb91dc24ebd6 · 2020-05-23T09:34:32.000+02:00
This PR was merged into the 3.4 branch. Discussion ---------- [VarDumper] ReflectionFunction::isDisabled() is deprecated | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #36872 | License | MIT | Doc PR | N/A See php/php-src#5473. Calling `ReflectionFunction::isDisabled()` is pointless on php 8 and doing so triggers a deprecation warning. Someone who is more familiar with that component might want to have a second look on this PR. I'm not really sure if this is the right way to fix the issue. Commits ------- 1da347e [VarDumper] ReflectionFunction::isDisabled() is deprecated.
diff --git a/src/Symfony/Component/VarDumper/Caster/ReflectionCaster.php b/src/Symfony/Component/VarDumper/Caster/ReflectionCaster.php
@@ -333,6 +333,10 @@ private static function addExtra(&$a, \Reflector $c)
     private static function addMap(&$a, \Reflector $c, $map, $prefix = Caster::PREFIX_VIRTUAL)
     {
         foreach ($map as $k => $m) {
+            if (\PHP_VERSION_ID >= 80000 && 'isDisabled' === $k) {
+                continue;
+            }
+
             if (method_exists($c, $m) && false !== ($m = $c->$m()) && null !== $m) {
                 $a[$prefix.$k] = $m instanceof \Reflector ? $m->name : $m;
             }

Original file line number	Diff line number	Diff line change
`@@ -333,6 +333,10 @@ private static function addExtra(&$a, \Reflector $c)`
`333`	`333`	`private static function addMap(&$a, \Reflector $c, $map, $prefix = Caster::PREFIX_VIRTUAL)`
`334`	`334`	`{`
`335`	`335`	`foreach ($map as $k => $m) {`
	`336`	`+ if (\PHP_VERSION_ID >= 80000 && 'isDisabled' === $k) {`
	`337`	`+ continue;`
	`338`	`+ }`
	`339`	`+`
`336`	`340`	`if (method_exists($c, $m) && false !== ($m = $c->$m()) && null !== $m) {`
`337`	`341`	`$a[$prefix.$k] = $m instanceof \Reflector ? $m->name : $m;`
`338`	`342`	`}`