Avoid an extra loop

antograssiot · antograssiot · commit fb0ccf9b87ef · 2018-04-02T21:44:48.000+02:00
...and keep the diff as small as possible
diff --git a/src/Symfony/Component/Yaml/Parser.php b/src/Symfony/Component/Yaml/Parser.php
@@ -421,21 +421,16 @@ private function doParse($value, $flags)
                 }
 
                 // try to parse the value as a multi-line string as a last resort
-                if (0 === $this->currentLineNb && 1 < $this->totalNumberOfLines) {
-                    // If the indentation is not consistent at offset 0, it is to be considered as a ParseError
-                    if (0 === $this->offset && !$deprecatedUsage) {
-                        foreach ($this->lines as $line) {
-                            if (rtrim($line) !== trim($line)) {
-                                throw new ParseException('Unable to parse.', $this->getRealCurrentLineNb() + 1, $this->currentLine, $this->filename);
-                            }
-                        }
-                    }
-
+                if (0 === $this->currentLineNb) {
                     $previousLineWasNewline = false;
                     $previousLineWasTerminatedWithBackslash = false;
                     $value = '';
 
                     foreach ($this->lines as $line) {
+                        // If the indentation is not consistent at offset 0, it is to be considered as a ParseError
+                        if (0 === $this->offset && !$deprecatedUsage && isset($line[0]) && ' ' === $line[0]) {
+                            throw new ParseException('Unable to parse.', $this->getRealCurrentLineNb() + 1, $this->currentLine, $this->filename);
+                        }
                         if ('' === trim($line)) {
                             $value .= "\n";
                         } elseif (!$previousLineWasNewline && !$previousLineWasTerminatedWithBackslash) {
