8000 minor #27418 Remove unneeded comments in tests (fabpot) · symfony/symfony@fa7bec4 · GitHub
[go: up one dir, main page]
Skip to content

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit fa7bec4

Browse files
fabpotfabpot
committed
minor #27418 Remove unneeded comments in tests (fabpot)
This PR was merged into the 2.8 branch. Discussion ---------- Remove unneeded comments in tests | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | License | MIT <!-- Write a short README entry for your feature/bugfix here (replace this comment block.) This will help people understand your PR and can be used as a start of the Doc PR. Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> Commits ------- 09c660d removed unneeded comments in tests
2 parents 785b431 + 09c660d commit fa7bec4

File tree

1 file changed

+0
-64
lines changed

1 file changed

+0
-64
lines changed

‎src/Symfony/Component/OptionsResolver/Tests/OptionsResolver2Dot6Test.php

Lines changed: 0 additions & 64 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,6 @@ protected function setUp()
2929
$this->resolver = new OptionsResolver();
3030
}
3131

32-
////////////////////////////////////////////////////////////////////////////
33-
// resolve()
34-
////////////////////////////////////////////////////////////////////////////
35-
3632
/**
3733
* @expectedException \Symfony\Component\OptionsResolver\Exception\UndefinedOptionsException
3834
* @expectedExceptionMessage The option "foo" does not exist. Defined options are: "a", "z".
@@ -69,10 +65,6 @@ public function testResolveFailsFromLazyOption()
6965
$this->resolver->resolve();
7066
}
7167

72-
////////////////////////////////////////////////////////////////////////////
73-
// setDefault()/hasDefault()
74-
////////////////////////////////////////////////////////////////////////////
75-
7668
public function testSetDefaultReturnsThis()
7769
{
7870
$this->assertSame($this->resolver, $this->resolver->setDefault('foo', 'bar'));
@@ -115,10 +107,6 @@ public function testHasDefaultWithNullValue()
115107
$this->assertTrue($this->resolver->hasDefault('foo'));
116108
}
117109

118-
////////////////////////////////////////////////////////////////////////////
119-
// lazy setDefault()
120-
////////////////////////////////////////////////////////////////////////////
121-
122 8000 110
public function testSetLazyReturnsThis()
123111
{
124112
$this->assertSame($this->resolver, $this->resolver->setDefault('foo', function (Options $options) {}));
@@ -232,10 +220,6 @@ public function testInvokeEachLazyOptionOnlyOnce()
232220
$this->assertSame(2, $calls);
233221
}
234222

235-
////////////////////////////////////////////////////////////////////////////
236-
// setRequired()/isRequired()/getRequiredOptions()
237-
////////////////////////////////////////////////////////////////////////////
238-
239223
public function testSetRequiredReturnsThis()
240224
{
241225
$this->assertSame($this->resolver, $this->resolver->setRequired('foo'));
@@ -330,10 +314,6 @@ public function testGetRequiredOptions()
330314
$this->assertSame(array('foo', 'bar'), $this->resolver->getRequiredOptions());
331315
}
332316

333-
////////////////////////////////////////////////////////////////////////////
334-
// isMissing()/getMissingOptions()
335-
////////////////////////////////////////////////////////////////////////////
336-
337317
public function testIsMissingIfNotSet()
338318
{
339319
$this->assertFalse($this->resolver->isMissing('foo'));
@@ -373,10 +353,6 @@ public function testGetMissingOptions()
373353
$this->assertSame(array('bar'), $this->resolver->getMissingOptions());
374354
}
375355

376-
////////////////////////////////////////////////////////////////////////////
377-
// setDefined()/isDefined()/getDefinedOptions()
378-
////////////////////////////////////////////////////////////////////////////
379-
380356
/**
381357
* @expectedException \Symfony\Component\OptionsResolver\Exception\AccessException
382358
*/
@@ -474,10 +450,6 @@ public function testClearedOptionsAreNotDefined()
474450
$this->assertFalse($this->resolver->isDefined('foo'));
475451
}
476452

477-
////////////////////////////////////////////////////////////////////////////
478-
// setAllowedTypes()
479-
////////////////////////////////////////////////////////////////////////////
480-
481453
/**
482454
* @expectedException \Symfony\Component\OptionsResolver\Exception\UndefinedOptionsException
483455
*/
@@ -568,10 +540,6 @@ public function testResolveSucceedsIfInstanceOfClass()
568540
$this->assertNotEmpty($this->resolver->resolve());
569541
}
570542

571-
////////////////////////////////////////////////////////////////////////////
572-
// addAllowedTypes()
573-
////////////////////////////////////////////////////////////////////////////
574-
575543
/**
576544
* @expectedException \Symfony\Component\OptionsResolver\Exception\UndefinedOptionsException
577545
*/
@@ -654,10 +622,6 @@ public function testAddAllowedTypesDoesNotOverwrite2()
654622
$this->assertNotEmpty($this->resolver->resolve());
655623
}
656624

657-
////////////////////////////////////////////////////////////////////////////
658-
// setAllowedValues()
659-
////////////////////////////////////////////////////////////////////////////
660-
661625
/**
662626
* @expectedException \Symfony\Component\OptionsResolver\Exception\UndefinedOptionsException
663627
*/
@@ -809,10 +773,6 @@ function () { return false; },
809773
$this->assertEquals(array('foo' => 'bar'), $this->resolver->resolve());
810774
}
811775

812-
////////////////////////////////////////////////////////////////////////////
813-
// addAllowedValues()
814-
////////////////////////////////////////////////////////////////////////////
815-
816776
/**
817777
* @expectedException \Symfony\Component\OptionsResolver\Exception\UndefinedOptionsException
818778
*/
@@ -929,10 +889,6 @@ public function testResolveSucceedsIfAnyAddedClosureReturnsTrue2()
929889
$this->assertEquals(array('foo' => 'bar'), $this->resolver->res A3E2 olve());
930890
}
931891

932-
////////////////////////////////////////////////////////////////////////////
933-
// setNormalizer()
934-
////////////////////////////////////////////////////////////////////////////
935-
936892
public function testSetNormalizerReturnsThis()
937893
{
938894
$this->resolver->setDefault('foo', 'bar');
@@ -1184,10 +1140,6 @@ public function testNormalizerNotCalledForUnsetOptions()
11841140
$this->assertEmpty($this->resolver->resolve());
11851141
}
11861142

1187-
////////////////////////////////////////////////////////////////////////////
1188-
// setDefaults()
1189-
////////////////////////////////////////////////////////////////////////////
1190-
11911143
public function testSetDefaultsReturnsThis()
11921144
{
11931145
$this->assertSame($this->resolver, $this->resolver->setDefaults(array('foo', 'bar')));
@@ -1222,10 +1174,6 @@ public function testFailIfSetDefaultsFromLazyOption()
12221174
$this->resolver->resolve();
12231175
}
12241176

1225-
////////////////////////////////////////////////////////////////////////////
1226-
// remove()
1227-
////////////////////////////////////////////////////////////////////////////
1228-
12291177
public function testRemoveReturnsThis()
12301178
{
12311179
$this->resolver->setDefault('foo', 'bar');
@@ -1314,10 +1262,6 @@ public function testRemoveUnknownOptionIgnored()
13141262
$this->assertNotNull($this->resolver->remove('foo'));
13151263
}
13161264

1317-
////////////////////////////////////////////////////////////////////////////
1318-
// clear()
1319-
////////////////////////////////////////////////////////////////////////////
1320-
13211265
public function testClearReturnsThis()
13221266
{
13231267
$this->assertSame($this->resolver, $this->resolver->clear());
@@ -1404,10 +1348,6 @@ public function testClearOptionAndNormalizer()
14041348
$this->assertEmpty($this->resolver->resolve());
14051349
}
14061350

1407-
////////////////////////////////////////////////////////////////////////////
1408-
// ArrayAccess
1409-
////////////////////////////////////////////////////////////////////////////
1410-
14111351
public function testArrayAccess()
14121352
{
14131353
$this->resolver->setDefault('default1', 0);
@@ -1522,10 +1462,6 @@ public function testFailIfCyclicDependency()
15221462
$this->resolver->resolve();
15231463
}
15241464

1525-
////////////////////////////////////////////////////////////////////////////
1526-
// Countable
1527-
////////////////////////////////////////////////////////////////////////////
1528-
15291465
public function testCount()
15301466
{
15311467
$this->resolver->setDefault('default', 0);

0 commit comments

Comments
 (0)
0