Send HTTP request to download the manifest only when necessary. The async/lazy mecanism must be explicit if an optimisation is necessary.

GromNaN · GromNaN · commit fa279bdd02c7 · 2020-02-21T17:55:07.000+01:00
diff --git a/src/Symfony/Component/Asset/VersionStrategy/RemoteJsonManifestVersionStrategy.php b/src/Symfony/Component/Asset/VersionStrategy/RemoteJsonManifestVersionStrategy.php
@@ -11,9 +11,7 @@
 
 namespace Symfony\Component\Asset\VersionStrategy;
 
-use Symfony\Contracts\HttpClient\Exception\ExceptionInterface;
 use Symfony\Contracts\HttpClient\HttpClientInterface;
-use Symfony\Contracts\HttpClient\ResponseInterface;
 
 /**
  * Reads the versioned path of an asset from a remote JSON manifest file.
@@ -29,21 +27,16 @@
 class RemoteJsonManifestVersionStrategy implements VersionStrategyInterface
 {
     private $manifestData;
-
-    /**
-     * @var ResponseInterface
-     */
-    private $httpResponse;
+    private $manifestUrl;
+    private $httpClient;
 
     /**
      * @param string $manifestUrl Absolute URL to the manifest file
      */
     public function __construct(string $manifestUrl, HttpClientInterface $httpClient)
     {
-        $this->httpResponse = $httpClient->request('GET', $manifestUrl, [
-            'headers' => ['accept' => 'application/json'],
-            'buffer' => true,
-        ]);
+        $this->manifestUrl = $manifestUrl;
+        $this->httpClient = $httpClient;
     }
 
     /**
@@ -64,11 +57,10 @@ public function applyVersion(string $path)
     private function getManifestPath(string $path): ?string
     {
         if (null === $this->manifestData) {
-            try {
-                $this->manifestData = $this->httpResponse->toArray();
-            } catch (ExceptionInterface $e) {
-                throw new \RuntimeException(sprintf('Error loading asset manifest from URL "%s"', $this->httpResponse->getInfo()['url']), 0, $e);
-            }
+            $this->manifestData = $this->httpClient->request('GET', $this->manifestUrl, [
+                'headers' => ['accept' => 'application/json'],
+                'buffer' => true,
+            ])->toArray();
         }
 
         return $this->manifestData[$path] ?? null;
