[BroserKit] Enable passthrew header information on submit

CFJulien · CFJulien · commit fa2063efe431 · 2018-04-06T12:52:03.000+02:00
This enables browser Testingtools like mink to pass headerfiles while doing a form submmit
diff --git a/src/Symfony/Component/BrowserKit/Client.php b/src/Symfony/Component/BrowserKit/Client.php
@@ -289,11 +289,11 @@ public function click(Link $link)
      *
      * @return Crawler
      */
-    public function submit(Form $form, array $values = array())
+    public function submit(Form $form, array $values = array(), $serverParameters = array())
     {
         $form->setValues($values);
 
-        return $this->request($form->getMethod(), $form->getUri(), $form->getPhpValues(), $form->getPhpFiles());
+        return $this->request($form->getMethod(), $form->getUri(), $form->getPhpValues(), $form->getPhpFiles(), $serverParameters);
     }
 
     /**
diff --git a/src/Symfony/Component/BrowserKit/Tests/ClientTest.php b/src/Symfony/Component/BrowserKit/Tests/ClientTest.php
@@ -367,6 +367,20 @@ public function testSubmitPreserveAuth()
         $this->assertEquals('bar', $server['PHP_AUTH_PW']);
     }
 
+    public function testSubmitPassthrewHeaders()
+    {
+        $client = new TestClient();
+        $client->setNextResponse(new Response('<html><form action="/foo"><input type="submit" /></form></html>'));
+        $crawler = $client->request('GET', 'http://www.example.com/foo/foobar');
+        $headers = array('Accept-Language' => 'de');
+
+        $client->submit($crawler->filter('input')->form(), array(), $headers);
+
+        $server = $client->getRequest()->getServer();
+        $this->assertArrayHasKey('Accept-Language', $server);
+        $this->assertEquals('de', $server['Accept-Language']);
+    }
+
     public function testFollowRedirect()
     {
         $client = new TestClient();

Original file line number	Diff line number	Diff line change
`@@ -289,11 +289,11 @@ public function click(Link $link)`
`289`	`289`	`*`
`290`	`290`	`* @return Crawler`
`291`	`291`	`*/`
`292`		`- public function submit(Form $form, array $values = array())`
	`292`	`+ public function submit(Form $form, array $values = array(), $serverParameters = array())`
`293`	`293`	`{`
`294`	`294`	`$form->setValues($values);`
`295`	`295`
`296`		`- return $this->request($form->getMethod(), $form->getUri(), $form->getPhpValues(), $form->getPhpFiles());`
	`296`	`+ return $this->request($form->getMethod(), $form->getUri(), $form->getPhpValues(), $form->getPhpFiles(), $serverParameters);`
`297`	`297`	`}`
`298`	`298`
`299`	`299`	`/**`