Fix deprecations on PHP 8.3

nicolas-grekas · nicolas-grekas · commit f9eb2cf886fd · 2023-07-19T22:11:33.000+02:00
diff --git a/src/Symfony/Component/Console/Tests/TerminalTest.php b/src/Symfony/Component/Console/Tests/TerminalTest.php
@@ -41,7 +41,7 @@ private function resetStatics()
         foreach (['height', 'width', 'stty'] as $name) {
             $property = new \ReflectionProperty(Terminal::class, $name);
             $property->setAccessible(true);
-            $property->setValue(null);
+            $property->setValue(null, null);
         }
     }
 
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Compiler/RegisterAutoconfigureAttributesPassTest.php b/src/Symfony/Component/DependencyInjection/Tests/Compiler/RegisterAutoconfigureAttributesPassTest.php
@@ -35,9 +35,6 @@ public function testProcess()
         (new RegisterAutoconfigureAttributesPass())->process($container);
 
         $argument = new BoundArgument(1, false, BoundArgument::INSTANCEOF_BINDING, realpath(__DIR__.'/../Fixtures/AutoconfigureAttributed.php'));
-        $values = $argument->getValues();
-        --$values[1];
-        $argument->setValues($values);
 
         $expected = (new ChildDefinition(''))
             ->setLazy(true)
diff --git a/src/Symfony/Component/HttpFoundation/Tests/RequestTest.php b/src/Symfony/Component/HttpFoundation/Tests/RequestTest.php
@@ -1882,7 +1882,7 @@ private function disableHttpMethodParameterOverride()
         $class = new \ReflectionClass(Request::class);
         $property = $class->getProperty('httpMethodParameterOverride');
         $property->setAccessible(true);
-        $property->setValue(false);
+        $property->setValue(null, false);
     }
 
     private function getRequestInstanceForClientIpTests(string $remoteAddr, ?string $httpForwardedFor, ?array $trustedProxies): Request
diff --git a/src/Symfony/Component/Messenger/Bridge/Redis/Transport/Connection.php b/src/Symfony/Component/Messenger/Bridge/Redis/Transport/Connection.php
@@ -346,7 +346,7 @@ public function get(): ?array
         $now = microtime();
         $now = substr($now, 11).substr($now, 2, 3);
 
-        $queuedMessageCount = $this->rawCommand('ZCOUNT', 0, $now);
+        $queuedMessageCount = $this->rawCommand('ZCOUNT', 0, $now) ?? 0;
 
         while ($queuedMessageCount--) {
             if (!$message = $this->rawCommand('ZPOPMIN', 1)) {

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ private function resetStatics()`
`41`	`41`	`foreach (['height', 'width', 'stty'] as $name) {`
`42`	`42`	`$property = new \ReflectionProperty(Terminal::class, $name);`
`43`	`43`	`$property->setAccessible(true);`
`44`		`- $property->setValue(null);`
	`44`	`+ $property->setValue(null, null);`
`45`	`45`	`}`
`46`	`46`	`}`
`47`	`47`
Original file line number	Diff line number	Diff line change
`@@ -1882,7 +1882,7 @@ private function disableHttpMethodParameterOverride()`
`1882`	`1882`	`$class = new \ReflectionClass(Request::class);`
`1883`	`1883`	`$property = $class->getProperty('httpMethodParameterOverride');`
`1884`	`1884`	`$property->setAccessible(true);`
`1885`		`- $property->setValue(false);`
	`1885`	`+ $property->setValue(null, false);`
`1886`	`1886`	`}`
`1887`	`1887`
`1888`	`1888`	`private function getRequestInstanceForClientIpTests(string $remoteAddr, ?string $httpForwardedFor, ?array $trustedProxies): Request`