Review

VincentLanglet · VincentLanglet · commit f9e36abd6264 · 2022-09-13T00:03:47.000+02:00
diff --git a/src/Symfony/Component/Form/DataTransformerInterface.php b/src/Symfony/Component/Form/DataTransformerInterface.php
@@ -18,8 +18,8 @@
  *
  * @author Bernhard Schussek <bschussek@gmail.com>
  *
- * @template T
- * @template R
+ * @template TValue
+ * @template TTransformedValue
  */
 interface DataTransformerInterface
 {
@@ -56,11 +56,9 @@ interface DataTransformerInterface
      * of the first data transformer outputs NULL, the second must be able to
      * process that value.
      *
-     * @param mixed $value The value in the original representation
-     * @psalm-param T|null $value
+     * @param TValue|null $value The value in the original representation
      *
-     * @return mixed
-     * @psalm-return R|null
+     * @return TTransformedValue|null
      *
      * @throws TransformationFailedException when the transformation fails
      */
@@ -87,11 +85,9 @@ public function transform(mixed $value);
      * By convention, reverseTransform() should return NULL if an empty string
      * is passed.
      *
-     * @param mixed $value The value in the transformed representation
-     * @psalm-param R|null $value
+     * @param TTransformedValue|null $value The value in the transformed representation
      *
-     * @return mixed
-     * @psalm-return T|null
+     * @return TValue|null
      *
      * @throws TransformationFailedException when the transformation fails
      */
diff --git a/src/Symfony/Component/Form/Extension/Core/DataTransformer/BaseDateTimeTransformer.php b/src/Symfony/Component/Form/Extension/Core/DataTransformer/BaseDateTimeTransformer.php
@@ -15,8 +15,8 @@
 use Symfony\Component\Form\Exception\InvalidArgumentException;
 
 /**
- * @template R
- * @implements DataTransformerInterface<\DateTimeInterface, R>
+ * @template TTransformedValue
+ * @implements DataTransformerInterface<\DateTimeInterface, TTransformedValue>
  */
 abstract class BaseDateTimeTransformer implements DataTransformerInterface
 {
diff --git a/src/Symfony/Component/Form/Extension/Core/DataTransformer/DateTimeToHtml5LocalDateTimeTransformer.php b/src/Symfony/Component/Form/Extension/Core/DataTransformer/DateTimeToHtml5LocalDateTimeTransformer.php
@@ -31,7 +31,7 @@ class DateTimeToHtml5LocalDateTimeTransformer extends BaseDateTimeTransformer
      * input is an RFC3339 date followed by 'T', followed by an RFC3339 time.
      * https://html.spec.whatwg.org/multipage/common-microsyntaxes.html#valid-local-date-and-time-string
      *
-     * @param \DateTimeInterface $dateTime A DateTime object
+     * @param \DateTimeInterface $dateTime
      *
      * @throws TransformationFailedException If the given value is not an
      *                                       instance of \DateTime or \DateTimeInterface

Original file line number	Diff line number	Diff line change
`@@ -18,8 +18,8 @@`
`18`	`18`	`*`
`19`	`19`	`* @author Bernhard Schussek <bschussek@gmail.com>`
`20`	`20`	`*`
`21`		`- * @template T`
`22`		`- * @template R`
	`21`	`+ * @template TValue`
	`22`	`+ * @template TTransformedValue`
`23`	`23`	`*/`
`24`	`24`	`interface DataTransformerInterface`
`25`	`25`	`{`
`@@ -56,11 +56,9 @@ interface DataTransformerInterface`
`56`	`56`	`* of the first data transformer outputs NULL, the second must be able to`
`57`	`57`	`* process that value.`
`58`	`58`	`*`
`59`		`- * @param mixed $value The value in the original representation`
`60`		`- * @psalm-param T\|null $value`
	`59`	`+ * @param TValue\|null $value The value in the original representation`
`61`	`60`	`*`
`62`		`- * @return mixed`
`63`		`- * @psalm-return R\|null`
	`61`	`+ * @return TTransformedValue\|null`
`64`	`62`	`*`
`65`	`63`	`* @throws TransformationFailedException when the transformation fails`
`66`	`64`	`*/`
`@@ -87,11 +85,9 @@ public function transform(mixed $value);`
`87`	`85`	`* By convention, reverseTransform() should return NULL if an empty string`
`88`	`86`	`* is passed.`
`89`	`87`	`*`
`90`		`- * @param mixed $value The value in the transformed representation`
`91`		`- * @psalm-param R\|null $value`
	`88`	`+ * @param TTransformedValue\|null $value The value in the transformed representation`
`92`	`89`	`*`
`93`		`- * @return mixed`
`94`		`- * @psalm-return T\|null`
	`90`	`+ * @return TValue\|null`
`95`	`91`	`*`
`96`	`92`	`* @throws TransformationFailedException when the transformation fails`
`97`	`93`	`*/`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ class DateTimeToHtml5LocalDateTimeTransformer extends BaseDateTimeTransformer`
`31`	`31`	`* input is an RFC3339 date followed by 'T', followed by an RFC3339 time.`
`32`	`32`	`* https://html.spec.whatwg.org/multipage/common-microsyntaxes.html#valid-local-date-and-time-string`
`33`	`33`	`*`
`34`		`- * @param \DateTimeInterface $dateTime A DateTime object`
	`34`	`+ * @param \DateTimeInterface $dateTime`
`35`	`35`	`*`
`36`	`36`	`* @throws TransformationFailedException If the given value is not an`
`37`	`37`	`* instance of \DateTime or \DateTimeInterface`