minor #22324 [HttpFoundation] Fix transient tests (nicolas-grekas)

fabpot · fabpot · commit f9d5ede9c646 · 2017-04-06T16:38:46.000-07:00
This PR was merged into the 2.8 branch. Discussion ---------- [HttpFoundation] Fix transient tests | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - We need to call `time()` when creating `DateTime` objects so that the clock-mock system can work. This fixes some newly introduced transient tests. ping @mpdude FYI Commits ------- 9f7a6bb [HttpFoundation] Fix transient tests
diff --git a/src/Symfony/Component/HttpFoundation/Response.php b/src/Symfony/Component/HttpFoundation/Response.php
@@ -204,7 +204,7 @@ public function __construct($content = '', $status = 200, $headers = array())
 
         /* RFC2616 - 14.18 says all Responses need to have a Date */
         if (!$this->headers->has('Date')) {
-            $this->setDate(new \DateTime(null, new \DateTimeZone('UTC')));
+            $this->setDate(\DateTime::createFromFormat('U', time()));
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -204,7 +204,7 @@ public function __construct($content = '', $status = 200, $headers = array())`
`204`	`204`
`205`	`205`	`/* RFC2616 - 14.18 says all Responses need to have a Date */`
`206`	`206`	`if (!$this->headers->has('Date')) {`
`207`		`- $this->setDate(new \DateTime(null, new \DateTimeZone('UTC')));`
	`207`	`+ $this->setDate(\DateTime::createFromFormat('U', time()));`
`208`	`208`	`}`
`209`	`209`	`}`
`210`	`210`