bug #34570 [FrameworkBundle][Notifier] Fixing notifier email definition without mailer (chr-hertel)

fabpot · fabpot · commit f888dbf58823 · 2019-11-24T18:34:31.000+01:00
This PR was merged into the 5.0 branch. Discussion ---------- [FrameworkBundle][Notifier] Fixing notifier email definition without mailer | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | I ran into this while having notifier and messenger but no mailer installed. definition `notifier.channel.email` gets removed in line 1934 if mailer is not enabled so we can't replace the argument. ``` In ContainerBuilder.php line 980: You have requested a non-existent service "notifier.channel.email". ``` Commits ------- f12b0c7 only replace argument if mailer is present
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
@@ -1941,7 +1941,9 @@ private function registerNotifierConfiguration(array $config, ContainerBuilder $
 
             // as we have a bus, the channels don't need the transports
             $container->getDefinition('notifier.channel.chat')->setArgument(0, null);
-            $container->getDefinition('notifier.channel.email')->setArgument(0, null);
+            if ($container->hasDefinition('notifier.channel.email')) {
+                $container->getDefinition('notifier.channel.email')->setArgument(0, null);
+            }
             $container->getDefinition('notifier.channel.sms')->setArgument(0, null);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -1941,7 +1941,9 @@ private function registerNotifierConfiguration(array $config, ContainerBuilder $`
`1941`	`1941`
`1942`	`1942`	`// as we have a bus, the channels don't need the transports`
`1943`	`1943`	`$container->getDefinition('notifier.channel.chat')->setArgument(0, null);`
`1944`		`- $container->getDefinition('notifier.channel.email')->setArgument(0, null);`
	`1944`	`+ if ($container->hasDefinition('notifier.channel.email')) {`
	`1945`	`+ $container->getDefinition('notifier.channel.email')->setArgument(0, null);`
	`1946`	`+ }`
`1945`	`1947`	`$container->getDefinition('notifier.channel.sms')->setArgument(0, null);`
`1946`	`1948`	`}`
`1947`	`1949`