filter out empty HTTP header parts

xabbuh · xabbuh · commit f882e3a49d6f · 2024-05-13T17:06:53.000+02:00
diff --git a/src/Symfony/Component/HttpFoundation/HeaderUtils.php b/src/Symfony/Component/HttpFoundation/HeaderUtils.php
@@ -289,6 +289,6 @@ private static function groupParts(array $matches, string $separators, bool $fir
             $parts[] = '' === $separators ? self::unquote($matches[0][0]) : self::groupParts($matches, $separators, false);
         }
 
-        return $parts;
+        return array_filter($parts);
     }
 }
diff --git a/src/Symfony/Component/HttpFoundation/Tests/AcceptHeaderTest.php b/src/Symfony/Component/HttpFoundation/Tests/AcceptHeaderTest.php
@@ -41,6 +41,7 @@ public static function provideFromStringData()
     {
         return [
             ['', []],
+            [';;;', []],
             ['gzip', [new AcceptHeaderItem('gzip')]],
             ['gzip,deflate,sdch', [new AcceptHeaderItem('gzip'), new AcceptHeaderItem('deflate'), new AcceptHeaderItem('sdch')]],
             ["gzip, deflate\t,sdch", [new AcceptHeaderItem('gzip'), new AcceptHeaderItem('deflate'), new AcceptHeaderItem('sdch')]],

Original file line number	Diff line number	Diff line change
`@@ -289,6 +289,6 @@ private static function groupParts(array $matches, string $separators, bool $fir`
`289`	`289`	`$parts[] = '' === $separators ? self::unquote($matches[0][0]) : self::groupParts($matches, $separators, false);`
`290`	`290`	`}`
`291`	`291`
`292`		`- return $parts;`
	`292`	`+ return array_filter($parts);`
`293`	`293`	`}`
`294`	`294`	`}`
Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,7 @@ public static function provideFromStringData()`
`41`	`41`	`{`
`42`	`42`	`return [`
`43`	`43`	`['', []],`
	`44`	`+ [';;;', []],`
`44`	`45`	`['gzip', [new AcceptHeaderItem('gzip')]],`
`45`	`46`	`['gzip,deflate,sdch', [new AcceptHeaderItem('gzip'), new AcceptHeaderItem('deflate'), new AcceptHeaderItem('sdch')]],`
`46`	`47`	`["gzip, deflate\t,sdch", [new AcceptHeaderItem('gzip'), new AcceptHeaderItem(' 3A89 deflate'), new AcceptHeaderItem('sdch')]],`