Support unicode characters in importmap regex

GregRbs92 · GregRbs92 · commit f77c85bd512d · 2024-10-25T01:56:48.000+02:00
Add the matcher \p{L} to the regex of `JavaScriptImportPathCompiler` so functions with non-latin characters still match the regex
diff --git a/src/Symfony/Component/AssetMapper/Compiler/JavaScriptImportPathCompiler.php b/src/Symfony/Component/AssetMapper/Compiler/JavaScriptImportPathCompiler.php
@@ -42,7 +42,7 @@ final class JavaScriptImportPathCompiler implements AssetCompilerInterface
             (?:                            # Import statements (script captured)
                 import\s*
                     (?:
-                        (?:\*\s*as\s+\w+|\s+[\w\s{},*]+)
+                        (?:\*\s*as\s+\w+|\s+[\p{L}\w\s{},*]+)
                         \s*from\s*
                     )?
             |
diff --git a/src/Symfony/Component/AssetMapper/Tests/Compiler/JavaScriptImportPathCompilerTest.php b/src/Symfony/Component/AssetMapper/Tests/Compiler/JavaScriptImportPathCompilerTest.php
@@ -172,6 +172,22 @@ public static function provideCompileTests(): iterable
             'expectedJavaScriptImports' => ['/assets/other.js' => ['lazy' => false, 'asset' => 'other.js', 'add' => true]],
         ];
 
+        yield 'static_named_import_with_unicode_character' => [
+            'input' => 'import { ɵmyFunction } from "./other.js";',
+            'expectedJavaScriptImports' => ['/assets/other.js' => ['lazy' => false, 'asset' => 'other.js', 'add' => true]],
+        ];
+
+        yield 'static_multiple_named_imports' => [
+            'input' => <<<EOF
+                import {
+                    myFunction,
+                    helperFunction
+                } from "./other.js";
+                EOF
+            ,
+            'expectedJavaScriptImports' => ['/assets/other.js' => ['lazy' => false, 'asset' => 'other.js', 'add' => true]],
+        ];
+
         yield 'static_import_everything' => [
             'input' => 'import * as myModule from "./other.js";',
             'expectedJavaScriptImports' => ['/assets/other.js' => ['lazy' => false, 'asset' => 'other.js', 'add' => true]],

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ final class JavaScriptImportPathCompiler implements AssetCompilerInterface`
`42`	`42`	`(?: # Import statements (script captured)`
`43`	`43`	`import\s*`
`44`	`44`	`(?:`
`45`		`- (?:\\sas\s+\w+\|\s+[\w\s{},*]+)`
	`45`	`+ (?:\\sas\s+\w+\|\s+[\p{L}\w\s{},*]+)`
`46`	`46`	`\sfrom\s`
`47`	`47`	`)?`
`48`	`48`	`\|`