Ensure overriding Command::execute() keep priority over __invoke

GromNaN · GromNaN · commit f77c4034ddcc · 2025-05-06T15:45:12.000+02:00
diff --git a/src/Symfony/Component/Console/Command/Command.php b/src/Symfony/Component/Console/Command/Command.php
@@ -134,7 +134,7 @@ public function __construct(?string $name = null)
             $this->setHelp($attribute?->help ?? '');
         }
 
-        if (\is_callable($this)) {
+        if (\is_callable($this) && (new \ReflectionMethod($this, 'execute'))->getDeclaringClass()->name === self::class) {
             $this->code = new InvokableCommand($this, $this(...));
         }
 
diff --git a/src/Symfony/Component/Console/Tests/Command/InvokableCommandTest.php b/src/Symfony/Component/Console/Tests/Command/InvokableCommandTest.php
@@ -21,7 +21,9 @@
 use Symfony\Component\Console\Exception\InvalidOptionException;
 use Symfony\Component\Console\Exception\LogicException;
 use Symfony\Component\Console\Input\ArrayInput;
+use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\NullOutput;
+use Symfony\Component\Console\Output\OutputInterface;
 
 class InvokableCommandTest extends TestCase
 {
@@ -142,6 +144,45 @@ public function testInvalidOptionType()
         $command->getDefinition();
     }
 
+    public function testExecuteHasPriorityOverInvokeMethod()
+    {
+        $command = new class extends Command {
+            public string $called;
+            protected function execute(InputInterface $input, OutputInterface $output): int
+            {
+                $this->called = __FUNCTION__;
+
+                return 0;
+            }
+
+            public function __invoke(): int
+            {
+                $this->called = __FUNCTION__;
+
+                return 0;
+            }
+        };
+
+        $command->run(new ArrayInput([]), new NullOutput());
+        $this->assertSame('execute', $command->called);
+    }
+
+    public function testCallInvokeMethodWhenExtendingCommandClass()
+    {
+        $command = new class extends Command {
+            public string $called;
+            public function __invoke(): int
+            {
+                $this->called = __FUNCTION__;
+
+                return 0;
+            }
+        };
+
+        $command->run(new ArrayInput([]), new NullOutput());
+        $this->assertSame('__invoke', $command->called);
+    }
+
     public function testInvalidReturnType()
     {
         $command = new Command('foo');

Original file line number	Diff line number	Diff line change
`@@ -134,7 +134,7 @@ public function __construct(?string $name = null)`
`134`	`134`	`$this->setHelp($attribute?->help ?? '');`
`135`	`135`	`}`
`136`	`136`
`137`		`- if (\is_callable($this)) {`
	`137`	`+ if (\is_callable($this) && (new \ReflectionMethod($this, 'execute'))->getDeclaringClass()->name === self::class) {`
`138`	`138`	`$this->code = new InvokableCommand($this, $this(...));`
`139`	`139`	`}`
`140`	`140`