Bug #16343 [Router] Too many Routes ?

Jelte Steijaert · Jelte Steijaert · commit f744e8d27fa5 · 2015-10-30T08:45:58.000+01:00
diff --git a/src/Symfony/Component/Routing/Generator/Dumper/PhpGeneratorDumper.php b/src/Symfony/Component/Routing/Generator/Dumper/PhpGeneratorDumper.php
@@ -53,7 +53,7 @@ public function dump(array $options = array())
  */
 class {$options['class']} extends {$options['base_class']}
 {
-    private \$declaredRoutes;
+    private static \$declaredRoutes;
 
     /**
      * Constructor.
@@ -62,7 +62,7 @@ public function __construct(RequestContext \$context, LoggerInterface \$logger =
     {
         \$this->context = \$context;
         \$this->logger = \$logger;
-        \$this->declaredRoutes = {$this->generateDeclaredRoutes()};
+        self::\$declaredRoutes = {$this->generateDeclaredRoutes()};
     }
 
 {$this->generateGenerateMethod()}
@@ -108,11 +108,11 @@ private function generateGenerateMethod()
         return <<<EOF
     public function generate(\$name, \$parameters = array(), \$referenceType = self::ABSOLUTE_PATH)
     {
-        if (!isset(\$this->declaredRoutes[\$name])) {
+        if (!isset(self::\$declaredRoutes[\$name])) {
             throw new RouteNotFoundException(sprintf('Unable to generate a URL for the named route "%s" as such route does not exist.', \$name));
         }
 
-        list(\$variables, \$defaults, \$requirements, \$tokens, \$hostTokens, \$requiredSchemes) = \$this->declaredRoutes[\$name];
+        list(\$variables, \$defaults, \$requirements, \$tokens, \$hostTokens, \$requiredSchemes) = self::\$declaredRoutes[\$name];
 
         return \$this->doGenerate(\$variables, \$defaults, \$requirements, \$tokens, \$parameters, \$name, \$referenceType, \$hostTokens, \$requiredSchemes);
     }

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ public function dump(array $options = array())`
`53`	`53`	`*/`
`54`	`54`	`class {$options['class']} extends {$options['base_class']}`
`55`	`55`	`{`
`56`		`- private \$declaredRoutes;`
	`56`	`+ private static \$declaredRoutes;`
`57`	`57`
`58`	`58`	`/**`
`59`	`59`	`* Constructor.`
`@@ -62,7 +62,7 @@ public function __construct(RequestContext \$context, LoggerInterface \$logger =`
`62`	`62`	`{`
`63`	`63`	`\$this->context = \$context;`
`64`	`64`	`\$this->logger = \$logger;`
`65`		`- \$this->declaredRoutes = {$this->generateDeclaredRoutes()};`
	`65`	`+ self::\$declaredRoutes = {$this->generateDeclaredRoutes()};`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`{$this->generateGenerateMethod()}`
`@@ -108,11 +108,11 @@ private function generateGenerateMethod()`
`108`	`108`	`return <<<EOF`
`109`	`109`	`public function generate(\$name, \$parameters = array(), \$referenceType = self::ABSOLUTE_PATH)`
`110`	`110`	`{`
`111`		`- if (!isset(\$this->declaredRoutes[\$name])) {`
	`111`	`+ if (!isset(self::\$declaredRoutes[\$name])) {`
`112`	`112`	`throw new RouteNotFoundException(sprintf('Unable to generate a URL for the named route "%s" as such route does not exist.', \$name));`
`113`	`113`	`}`
`114`	`114`
`115`		`- list(\$variables, \$defaults, \$requirements, \$tokens, \$hostTokens, \$requiredSchemes) = \$this->declaredRoutes[\$name];`
	`115`	`+ list(\$variables, \$defaults, \$requirements, \$tokens, \$hostTokens, \$requiredSchemes) = self::\$declaredRoutes[\$name];`
`116`	`116`
`117`	`117`	`return \$this->doGenerate(\$variables, \$defaults, \$requirements, \$tokens, \$parameters, \$name, \$referenceType, \$hostTokens, \$requiredSchemes);`
`118`	`118`	`}`