bug #53481 [Process] Fix executable finder when the command starts with a dash (kayw-geek)

nicolas-grekas · nicolas-grekas · commit f626a2c4bde6 · 2024-01-11T09:35:14.000+01:00
This PR was submitted for the 7.1 branch but it was merged into the 5.4 branch instead. Discussion ---------- [Process] Fix executable finder when the command starts with a dash | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #53479 | License | MIT Commits ------- 8ceaa8e [Process] Fix executable finder when the command starts with a dash
diff --git a/src/Symfony/Component/Process/PhpExecutableFinder.php b/src/Symfony/Component/Process/PhpExecutableFinder.php
@@ -35,7 +35,7 @@ public function find(bool $includeArgs = true)
     {
         if ($php = getenv('PHP_BINARY')) {
             if (!is_executable($php)) {
-                $command = '\\' === \DIRECTORY_SEPARATOR ? 'where' : 'command -v';
+                $command = '\\' === \DIRECTORY_SEPARATOR ? 'where' : 'command -v --';
                 if ($php = strtok(exec($command.' '.escapeshellarg($php)), \PHP_EOL)) {
                     if (!is_executable($php)) {
                         return false;

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ public function find(bool $includeArgs = true)`
`35`	`35`	`{`
`36`	`36`	`if ($php = getenv('PHP_BINARY')) {`
`37`	`37`	`if (!is_executable($php)) {`
`38`		`- $command = '\\' === \DIRECTORY_SEPARATOR ? 'where' : 'command -v';`
	`38`	`+ $command = '\\' === \DIRECTORY_SEPARATOR ? 'where' : 'command -v --';`
`39`	`39`	`if ($php = strtok(exec($command.' '.escapeshellarg($php)), \PHP_EOL)) {`
`40`	`40`	`if (!is_executable($php)) {`
`41`	`41`	`return false;`