bug #51726 [Validator] NoSuspiciousCharacters custom error messages fix (bam1to)

nicolas-grekas · nicolas-grekas · commit f47f58944640 · 2023-09-27T19:25:16.000+02:00
This PR was merged into the 6.3 branch. Discussion ---------- [Validator] NoSuspiciousCharacters custom error messages fix | Q | A | ------------- | --- | Branch? | 6.3 for bug fixes  | Bug fix? | yes | New feature? | no  | Deprecations? | no  | Tickets | Fix #51715  | License | MIT | Doc PR |  We use the ?? operator to check if the entered constructor arguments are equal to null. The previous operator (??=) was incorrect because of the default messages' values. Commits ------- 08e955f NoSuspiciousCharacters custom error messages fix
diff --git a/src/Symfony/Component/Validator/Constraints/NoSuspiciousCharacters.php b/src/Symfony/Component/Validator/Constraints/NoSuspiciousCharacters.php
@@ -102,12 +102,12 @@ public function __construct(
 
         parent::__construct($options, $groups, $payload);
 
-        $this->restrictionLevelMessage ??= $restrictionLevelMessage;
-        $this->invisibleMessage ??= $invisibleMessage;
-        $this->mixedNumbersMessage ??= $mixedNumbersMessage;
-        $this->hiddenOverlayMessage ??= $hiddenOverlayMessage;
-        $this->checks ??= $checks;
-        $this->restrictionLevel ??= $restrictionLevel;
-        $this->locales ??= $locales;
+        $this->restrictionLevelMessage = $restrictionLevelMessage ?? $this->restrictionLevelMessage;
+        $this->invisibleMessage = $invisibleMessage ?? $this->invisibleMessage;
+        $this->mixedNumbersMessage = $mixedNumbersMessage ?? $this->mixedNumbersMessage;
+        $this->hiddenOverlayMessage = $hiddenOverlayMessage ?? $this->hiddenOverlayMessage;
+        $this->checks = $checks ?? $this->checks;
+        $this->restrictionLevel = $restrictionLevel ?? $this->restrictionLevel;
+        $this->locales = $locales ?? $this->locales;
     }
 }
