minor #44638 [Workflow] Remove redundant type check (derrabus)

nicolas-grekas · nicolas-grekas · commit f3d3690eadd8 · 2021-12-15T14:53:23.000+01:00
This PR was merged into the 6.0 branch. Discussion ---------- [Workflow] Remove redundant type check | Q | A | ------------- | --- | Branch? | 6.1 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A `MarkingStoreInterface::getMarking()` has a native return type `Marking`. The type check I've removed here is thus 100% redundant and can be removed. Commits ------- 60b1672 [Workflow] Remove redundant type check
diff --git a/src/Symfony/Component/Workflow/Workflow.php b/src/Symfony/Component/Workflow/Workflow.php
@@ -83,10 +83,6 @@ public function getMarking(object $subject, array $context = []): Marking
     {
         $marking = $this->markingStore->getMarking($subject);
 
-        if (!$marking instanceof Marking) {
-            throw new LogicException(sprintf('The value returned by the MarkingStore is not an instance of "%s" for workflow "%s".', Marking::class, $this->name));
-        }
-
         // check if the subject is already in the workflow
         if (!$marking->getPlaces()) {
             if (!$this->definition->getInitialPlaces()) {
